Add the capability to accept group Paulis that can be measured using same measurement results#7236
Merged
eliottrosenberg merged 8 commits intoquantumlib:mainfrom May 1, 2025
Merged
Conversation
…een measured using the same measurement results
ddddddanni
changed the title
Collaborator
Author
|
Hey @eliottrosenberg and @NoureldinYosri if you could take a look at this. Thanks! |
eliottrosenberg
approved these changes
Apr 15, 2025
Collaborator
eliottrosenberg
left a comment
eliottrosenberg
left a comment
There was a problem hiding this comment.
LGTM! Thanks, @ddddddanni!
NoureldinYosri
requested changes
Apr 16, 2025
| return op1 == op2 | ||
|
|
||
|
|
||
| def _are_two_qwc( |
Collaborator
There was a problem hiding this comment.
please use a more descriptive name
| first_value = next(iter(circuits_to_pauli.values())) | ||
| for circuit, pauli_strs_list in circuits_to_pauli.items(): | ||
| if not isinstance(pauli_strs_list, list): | ||
| raise TypeError( |
Collaborator
There was a problem hiding this comment.
this is too restricitve ... what if the variable is a tuple or iterator? same below
Collaborator
Author
There was a problem hiding this comment.
Done! Change to check sequence instead of list.
| for circuit, paulis in circuits_to_pauli.items(): | ||
| normalized_circuits_to_pauli[circuit] = [[ps] for ps in paulis] # type: ignore[list-item] | ||
| return normalized_circuits_to_pauli | ||
| return circuits_to_pauli # type: ignore |
Collaborator
There was a problem hiding this comment.
why are all these ignore statements here?
Collaborator
Author
There was a problem hiding this comment.
Done! I use some cast to make the type as expected.
NoureldinYosri
approved these changes
Apr 29, 2025
Collaborator
NoureldinYosri
left a comment
NoureldinYosri
left a comment
There was a problem hiding this comment.
thanks @ddddddanni
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7236 +/- ##
========================================
Coverage 98.67% 98.67%
========================================
Files 1108 1108
Lines 96220 96407 +187
========================================
+ Hits 94942 95129 +187
Misses 1278 1278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2025
…same measurement results (#7236) * Modify the pauli string measurement tool to allow a group of paulis been measured using the same measurement results * Add more tests and fix some code * Fix format * Fix type * Fix lint * Make changes based on @NoureldinYosri's comments. * Fix format and coverage. Also optimize group pauli tests to make them finish quicker. --------- Co-authored-by: Noureldin <noureldinyosri@google.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 30, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…same measurement results (quantumlib#7236) * Modify the pauli string measurement tool to allow a group of paulis been measured using the same measurement results * Add more tests and fix some code * Fix format * Fix type * Fix lint * Make changes based on @NoureldinYosri's comments. * Fix format and coverage. Also optimize group pauli tests to make them finish quicker. --------- Co-authored-by: Noureldin <noureldinyosri@google.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
…uli_strings``` method (#7416) [PR #7236](#7236) adds the feature to measure groups of qubit-wise-commuting Pauli operators simultaneously. However, the current implementation generates a separate readout circuit for each individual Pauli operator within a group. This leads to non-simultaneous measurements, which is corrected in this PR.
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 25, 2025
…uli_strings``` method (quantumlib#7416) [PR quantumlib#7236](quantumlib#7236) adds the feature to measure groups of qubit-wise-commuting Pauli operators simultaneously. However, the current implementation generates a separate readout circuit for each individual Pauli operator within a group. This leads to non-simultaneous measurements, which is corrected in this PR.
ddddddanni
added a commit
to ddddddanni/Cirq
that referenced
this pull request
Jul 15, 2025
…uli_strings``` method (quantumlib#7416) [PR quantumlib#7236](quantumlib#7236) adds the feature to measure groups of qubit-wise-commuting Pauli operators simultaneously. However, the current implementation generates a separate readout circuit for each individual Pauli operator within a group. This leads to non-simultaneous measurements, which is corrected in this PR.
This was referenced Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an optimization to the tool responsible for measuring expectation values of Pauli strings (the tool was added in #7067). Previously, each Pauli string required separate measurement results for expectation calculation. By allowing gwc Pauli strings as a group, the tool can now measure the expectation values for multiple gwc pauli strings using a single set of measurement results.