Skip to content

Switch to unquoted type annotations part 9#7356

Merged
pavoljuhas merged 1 commit intoquantumlib:mainfrom
pavoljuhas:use-future-annotations-9
May 20, 2025
Merged

Switch to unquoted type annotations part 9#7356
pavoljuhas merged 1 commit intoquantumlib:mainfrom
pavoljuhas:use-future-annotations-9

Conversation

@pavoljuhas
Copy link
Copy Markdown
Collaborator

No change in the effective code. A batch of 250 files (~200 to go).
Added future import of annotations to detect typing-only imports.

Passes ruff check --target-version=py311 --select=UP037,TC001,TC002

Partially implements #1999

No change in the effective code.  A batch of 250 files (~200 to go).
Added future import of annotations to detect typing-only imports.

Passes  ruff check --target-version=py311 --select=UP037,TC001,TC002

Partially implements quantumlib#1999
@github-actions github-actions bot added the size: M 50< lines changed <250 label May 19, 2025
@pavoljuhas pavoljuhas requested a review from mhucka May 19, 2025 21:47
@codecov
Copy link
Copy Markdown

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (d0a150e) to head (32bc3e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7356    +/-   ##
========================================
  Coverage   98.67%   98.68%            
========================================
  Files        1112     1112            
  Lines       97258    97390   +132     
========================================
+ Hits        95973    96109   +136     
+ Misses       1285     1281     -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added this pull request to the merge queue May 19, 2025
Merged via the queue into quantumlib:main with commit aba6fbe May 20, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the use-future-annotations-9 branch May 20, 2025 00:11
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
No change in the effective code.  A batch of 250 files (~200 to go).
Added future import of annotations to detect typing-only imports.

Passes  ruff check --target-version=py311 --select=UP037,TC001,TC002

Partially implements quantumlib#1999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants