Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7364 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 1112 1112
Lines 97599 97588 -11
=======================================
- Hits 96315 96306 -9
+ Misses 1284 1282 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@pavoljuhas , @dstrain115 ruff check fix is missing a few type updates but suggests to fix manually, such as follows Cirq/cirq-core/cirq/value/type_alias.py Line 27 in e9a592d I am not sure if these can be updated to |
Yes, please go ahead with these manually. |
Passes ruff check --target-version=py311 --select=UP037,TC001,TC002,UP006,UP007
I don't see it on my side, perhaps there is some difference in your virtual environment. Lines 82 to 85 in e9a592d I have pushed badf4ca for the final issues detected by |
|
@pavoljuhas Thank you. I'll create a new environment. |
👍 Also, please use |
Updates following type annotations: - typing.Dict to dict - typing.List to list - typing.Tuple to tuple - typing.Set to set - typing.FrozenSet to frozenset - typing.Type to type - typing.Union to X | Y - typing.Optional to X | None Addresses issue [quantumlib#7339] --------- Co-authored-by: Pavol Juhas <juhas@google.com>


Updates following type annotations:
Addresses issue [#7339]