Skip to content

Update QVM demo notebooks to use willow_pink#7428

Merged
pavoljuhas merged 12 commits intoquantumlib:mainfrom
pavoljuhas:update-qvm-notebooks
Jun 26, 2025
Merged

Update QVM demo notebooks to use willow_pink#7428
pavoljuhas merged 12 commits intoquantumlib:mainfrom
pavoljuhas:update-qvm-notebooks

Conversation

@pavoljuhas
Copy link
Copy Markdown
Collaborator

The following quantum virtual machine notebooks were updated to use
the new willow_pink processor by default:

  • quantum_virtual_machine.ipynb
  • qvm_basic_example.ipynb
  • qvm_builder_code.ipynb
  • qvm_stabilizer_example.ipynb

Small fixups in other reviewed notebooks.

Related to b/395705720

@pavoljuhas pavoljuhas requested review from a team, verult, vtomole and wcourtney as code owners June 18, 2025 23:49
@github-actions github-actions bot added the size: M 50< lines changed <250 label Jun 18, 2025
@pavoljuhas
Copy link
Copy Markdown
Collaborator Author

NB: can be also reviewed per-commit.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (b1ff3ae) to head (40fcb1d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7428      +/-   ##
==========================================
- Coverage   98.69%   98.69%   -0.01%     
==========================================
  Files        1112     1112              
  Lines       97993    97993              
==========================================
- Hits        96714    96711       -3     
- Misses       1279     1282       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@eliottrosenberg eliottrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Pavol! General comment for all of these notebooks: let's always make "willow_pink" the default and maybe not even list the others since they are very old and people probably shouldn't be using them.

Comment thread docs/simulate/noisy_simulation.ipynb Outdated
"\n",
"processor_id = \"rainbow\" # or \"weber\"\n",
"# See cirq_google.engine.list_virtual_processors() for available processor names\n",
"processor_id = \"rainbow\" # or \"weber\" or \"willow_pink\"\n",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make "willow_pink" the default and maybe not even mention the others since they are very old and don't represent current performance.

Copy link
Copy Markdown
Collaborator Author

@pavoljuhas pavoljuhas Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 832175f.

I have reviewed other notebooks for their processor choice. The ones that run QVM simulations now all default to "willow_pink". I have left the old default processors in qubit_picking.ipynb where the low noise performance is not critical for the demonstrated function and the heatmap plots would become too dense for willow. I have also left the old default "weber" processor in virtual_engine_interface.ipynb which primarily demos interaction with Quantum Engine (processor choice, time reservation) and uses noise-free simulated processors.

I feel removing old processors might degrade some of the notebooks, for example, the virtual_engine_interface would end up having a choice of one processor instead of three.

Copy link
Copy Markdown
Collaborator

@eliottrosenberg eliottrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight preference to remove all of the references to Rainbow and Weber but it's okay if you don't want to.

@pavoljuhas pavoljuhas requested review from dstrain115 and mhucka June 24, 2025 21:22
@pavoljuhas pavoljuhas added this pull request to the merge queue Jun 26, 2025
Merged via the queue into quantumlib:main with commit 0df354c Jun 26, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the update-qvm-notebooks branch June 26, 2025 17:37
ddddddanni pushed a commit to ddddddanni/Cirq that referenced this pull request Jul 15, 2025
The following quantum virtual machine notebooks were updated to use
the new `willow_pink` processor by default:

- quantum_virtual_machine.ipynb
- qvm_basic_example.ipynb
- qvm_builder_code.ipynb
- qvm_stabilizer_example.ipynb

Small fixups in other reviewed notebooks.

Related to b/395705720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants