Skip to content

ruff - enable and fix ISC, implicit string concatenation#7511

Merged
pavoljuhas merged 5 commits intoquantumlib:mainfrom
pavoljuhas:ruff-activate-isc
Jul 18, 2025
Merged

ruff - enable and fix ISC, implicit string concatenation#7511
pavoljuhas merged 5 commits intoquantumlib:mainfrom
pavoljuhas:ruff-activate-isc

Conversation

@pavoljuhas
Copy link
Copy Markdown
Collaborator

@pavoljuhas pavoljuhas commented Jul 18, 2025

  • Enable ruff rule ISC for implicit string concatenation
  • Fix word-break across concatenated strings
  • ruff - fix ISC - implicit string concatenation issues
  • also fix pytest warning on always-matching empty pattern

No change in the effective code.

Partially implements #7505

@pavoljuhas pavoljuhas requested review from a team, mrwojtek, verult, vtomole and wcourtney as code owners July 18, 2025 18:15
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the size: M 50< lines changed <250 label Jul 18, 2025
@pavoljuhas pavoljuhas requested a review from mhucka July 18, 2025 18:18
@pavoljuhas pavoljuhas enabled auto-merge July 18, 2025 18:19
Copy link
Copy Markdown
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice.

@pavoljuhas pavoljuhas added this pull request to the merge queue Jul 18, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (cb60bba) to head (c1a6fcc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7511      +/-   ##
==========================================
- Coverage   98.68%   98.68%   -0.01%     
==========================================
  Files        1091     1091              
  Lines       96948    96948              
==========================================
- Hits        95673    95669       -4     
- Misses       1275     1279       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pavoljuhas pavoljuhas removed this pull request from the merge queue due to a manual request Jul 18, 2025
@pavoljuhas pavoljuhas enabled auto-merge July 18, 2025 18:32
@pavoljuhas
Copy link
Copy Markdown
Collaborator Author

This is nice.

Thanks! (inspired by 33188d9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants