THC prepare (#350)

* WIP.

* Updates.

* Refactor to use cirq bloqs.

* Update docstring.

* Finish conversion to cirq wrapped bloqs.

* Remove old file.

* Check alt keep values.

* Delete extra tutorial for later PR.

* Fix registers.

* Fix missing import.

* Update basic gates.

* WIP.

* Fix errors.

* Revert toffoli change.

* Tidy arithmetic t_complexity.

* Updates.

* Fix lint errors.

* Fix lint and cirq-ft version issue.

* Fixes.

* Updates for cirq interop.

* Fix decomposition.

* Fix formatting.

* Remove unused function.

* Fix reprs to avoid data arrays being printed in the output.

* Fix errors from merge.

* Fix import.

* Remove unused import.

* Add issue link.

* Fix trailing whitespace.

* Bump cirq version for arithmetic #6313 and #6312.

* Add arithmetic t_complexity calls to unit tests.

* Address review comments.

* Address review comments.

* Fix generalizer for pauli gates.

* Address review comments.

* Use qualtran bloqs.

* Remove unused code.

* Fix CZ bloq.

* [skip ci] WIP.

* replace multi control pauli.

* Correct classification.

* Group and bloqs.

* Better formatting for bloq counts.

* Add issue link about removing code.

* Fix lint and format errors.

---------

Co-authored-by: Matthew Harrigan <mpharrigan@google.com>

Author: fdmalone

dev_tools/autogenerate-bloqs-notebooks.py

@@ -59,6 +59,7 @@
 import qualtran.bloqs.basic_gates.toffoli_test
 import qualtran.bloqs.basic_gates.x_basis_test
 import qualtran.bloqs.basic_gates.z_basis_test
+import qualtran.bloqs.chemistry.thc_test
 import qualtran.bloqs.factoring.mod_exp
 import qualtran.bloqs.factoring.mod_exp_test
 import qualtran.bloqs.factoring.mod_mul_test
@@ -140,6 +141,15 @@
         ],
         directory=f'{SOURCE_DIR}/bloqs/factoring',
     ),
+    NotebookSpec(
+        title='Tensor Hypercontraction',
+        module=qualtran.bloqs.chemistry.thc,
+        gate_specs=[
+            BloqNbSpec(qualtran.bloqs.chemistry.thc_test._make_uniform_superposition),
+            BloqNbSpec(qualtran.bloqs.chemistry.thc_test._make_prepare),
+        ],
+        directory=f'{SOURCE_DIR}/bloqs/chemistry',
+    ),
 ]
 
 

qualtran/bloqs/arithmetic.py

@@ -1037,7 +1037,7 @@ def signature(self) -> Signature:
         return Signature.build(x=self.bitsize, target=1)
 
     def t_complexity(self) -> TComplexity:
-        return t_complexity(LessThanConstant(self.bitsize, val=self.val))
+        return t_complexity(LessThanConstant(self.bitsize, less_than_val=self.val))
 
     def bloq_counts(
         self, ssa: Optional['SympySymbolAllocator'] = None

qualtran/bloqs/arithmetic_test.py

@@ -351,6 +351,7 @@ def test_add():
     q1 = bb.add_register('b', bitsize)
     a, b = bb.add(Add(bitsize), a=q0, b=q1)
     cbloq = bb.finalize(a=a, b=b)
+    cbloq.t_complexity()
 
 
 @pytest.mark.parametrize('bitsize', [3])
@@ -402,6 +403,7 @@ def test_out_of_place_adder():
     q2 = bb.add_register('c', bitsize)
     a, b, c = bb.add(OutOfPlaceAdder(bitsize), a=q0, b=q1, c=q2)
     cbloq = bb.finalize(a=a, b=b, c=c)
+    cbloq.t_complexity()
 
 
 def test_square():
@@ -410,6 +412,7 @@ def test_square():
     q0 = bb.add_register('a', bitsize)
     q0, q1 = bb.add(Square(bitsize), a=q0)
     cbloq = bb.finalize(a=q0, result=q1)
+    cbloq.t_complexity()
 
 
 def test_sum_of_squares():
@@ -420,6 +423,7 @@ def test_sum_of_squares():
     inp, out = bb.add(SumOfSquares(bitsize, k), input=inp)
     cbloq = bb.finalize(input=inp, result=out)
     assert SumOfSquares(bitsize, k).signature[1].bitsize == 2 * bitsize + 2
+    cbloq.t_complexity()
 
 
 def test_product():
@@ -430,6 +434,7 @@ def test_product():
     q1 = bb.add_register('b', mbits)
     q0, q1, q2 = bb.add(Product(bitsize, mbits), a=q0, b=q1)
     cbloq = bb.finalize(a=q0, b=q1, result=q2)
+    cbloq.t_complexity()
 
 
 def test_scale_int_by_real():
@@ -438,6 +443,7 @@ def test_scale_int_by_real():
     q1 = bb.add_register('b', 8)
     q0, q1, q2 = bb.add(ScaleIntByReal(15, 8), real_in=q0, int_in=q1)
     cbloq = bb.finalize(a=q0, b=q1, result=q2)
+    cbloq.t_complexity()
 
 
 def test_multiply_two_reals():
@@ -446,6 +452,7 @@ def test_multiply_two_reals():
     q1 = bb.add_register('b', 15)
     q0, q1, q2 = bb.add(MultiplyTwoReals(15), a=q0, b=q1)
     cbloq = bb.finalize(a=q0, b=q1, result=q2)
+    cbloq.t_complexity()
 
 
 def test_square_real_number():
@@ -464,6 +471,7 @@ def test_greater_than():
     anc = bb.add_register('result', 1)
     q0, q1, anc = bb.add(GreaterThan(bitsize), a=q0, b=q1, target=anc)
     cbloq = bb.finalize(a=q0, b=q1, result=anc)
+    cbloq.t_complexity()
 
 
 def test_greater_than_constant():
@@ -473,6 +481,7 @@ def test_greater_than_constant():
     anc = bb.add_register('result', 1)
     q0, anc = bb.add(GreaterThanConstant(bitsize, 17), x=q0, target=anc)
     cbloq = bb.finalize(x=q0, result=anc)
+    cbloq.t_complexity()
 
 
 def test_equals_a_constant():
@@ -482,6 +491,7 @@ def test_equals_a_constant():
     anc = bb.add_register('result', 1)
     q0, anc = bb.add(EqualsAConstant(bitsize, 17), x=q0, target=anc)
     cbloq = bb.finalize(x=q0, result=anc)
+    cbloq.t_complexity()
 
 
 def test_to_contiguous_index():
@@ -492,6 +502,7 @@ def test_to_contiguous_index():
     out = bb.add_register('s', 1)
     q0, q1, out = bb.add(ToContiguousIndex(bitsize, 2 * bitsize), mu=q0, nu=q1, s=out)
     cbloq = bb.finalize(mu=q0, nu=q1, s=out)
+    cbloq.t_complexity()
 
 
 def test_arithmetic_notebook():

qualtran/bloqs/basic_gates/hadamard.py

@@ -17,6 +17,7 @@
 
 import numpy as np
 from attrs import frozen
+from cirq_ft import TComplexity
 
 from qualtran import Bloq, Signature, SoquetT
 
@@ -74,3 +75,6 @@ def as_cirq_op(
 
         (q,) = q
         return cirq.H(q), {'q': np.array([q])}
+
+    def t_complexity(self):
+        return TComplexity(clifford=1)

qualtran/bloqs/basic_gates/rotation.py

@@ -28,6 +28,7 @@
     import cirq
 
     from qualtran.cirq_interop import CirqQuregT
+    from qualtran.resource_counting import SympySymbolAllocator
 
 
 @frozen

qualtran/bloqs/basic_gates/toffoli.py

@@ -16,9 +16,11 @@
 from typing import Dict, Optional, Set, Tuple, TYPE_CHECKING, Union
 
 from attrs import frozen
+from cirq_ft import TComplexity
 
 from qualtran import Bloq, Register, Signature
 from qualtran.bloqs.basic_gates import TGate
+from qualtran.resource_counting import SympySymbolAllocator
 
 if TYPE_CHECKING:
     import cirq
@@ -50,6 +52,9 @@ def signature(self) -> Signature:
     def bloq_counts(self, ssa: Optional['SympySymbolAllocator'] = None) -> Set['BloqCountT']:
         return {(4, TGate())}
 
+    def t_complexity(self):
+        return TComplexity(t=4)
+
     def on_classical_vals(
         self, ctrl: 'ClassicalValT', target: 'ClassicalValT'
     ) -> Dict[str, 'ClassicalValT']:

qualtran/bloqs/basic_gates/x_basis.py

@@ -18,6 +18,7 @@
 import numpy as np
 import quimb.tensor as qtn
 from attrs import frozen
+from cirq_ft import TComplexity
 
 from qualtran import Bloq, Register, Side, Signature, SoquetT
 
@@ -177,3 +178,6 @@ def as_cirq_op(
 
         (q,) = q
         return cirq.X(q), {'q': [q]}
+
+    def t_complexity(self):
+        return TComplexity(clifford=1)

qualtran/bloqs/chemistry/__init__.py

@@ -0,0 +1,13 @@
+#  Copyright 2023 Google LLC
+#
+#  Licensed under the Apache License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at
+#
+#      https://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.