Merged
Conversation
Collaborator
Author
|
cc @mpharrigan |
mpharrigan
reviewed
Aug 15, 2023
mpharrigan
reviewed
Aug 15, 2023
mpharrigan
reviewed
Aug 15, 2023
mpharrigan
reviewed
Aug 15, 2023
3eb7076 to
202cf47
Compare
Collaborator
|
Is this ready for review? can you resolve conflicts? |
Collaborator
Author
|
I would look tomorrow if you have a chance. There were some dirty hacks in the mean time to do some accounting. |
Collaborator
Author
|
@mpharrigan PTAL |
Collaborator
Author
|
weird merging #419 closed this somehow. |
Collaborator
|
Any time you use the word "fixes" and an issue, apparently it will try to close the thing that it "fixes". Makes sense for issues (but clearly not for PRs) |
Collaborator
Author
|
So the comparator issue is now resolved since #394, which removes the need for my hacky code. I'll incorporate the changes and any CirqGateAsBloq deprecations as necessary before merging. |
mpharrigan
reviewed
Oct 17, 2023
Collaborator
mpharrigan
left a comment
There was a problem hiding this comment.
some more notebook things
Collaborator
Author
|
I've opened #425 to track the notebook_utils clean up. This is good to go I think @mpharrigan |
tanujkhattar
approved these changes
Oct 18, 2023
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add THC prepare bloqs: uniform superposition, and prepare.
Some issues which arose:
For tcomplexity to work I had to add t_complexity methods to several single qubit gatesTComplexity is currently broken, XGate doesn't support decompositionrelies on Add OnEach bloq #346 Multi controlled pauli #349 and Less than equal bloqs. #348Prepare t complexity is currently not working because controlled bloq (CZ) throws an error during decomposition (ZGate doesn't support decomposition).