Skip to content

Conversation

KaiSuchomel
Copy link
Contributor

We found the following NPE in our Log:

2025-08-22 11:21:50,801 WARN  [io.qua.lan.gem.com.GeminiChatLanguageModel] (efbdd8b9a7a18d1f1b062854ad2071a4::) Exception while calling model listener: java.lang.NullPointerException: Cannot invoke "java.lang.Double.doubleValue()" because the return value of "dev.langchain4j.model.chat.request.ChatRequestParameters.temperature()" is null
	at io.quarkiverse.langchain4j.runtime.listeners.SpanChatModelListener.onRequest(SpanChatModelListener.java:53)
	at io.quarkiverse.langchain4j.gemini.common.GeminiChatLanguageModel.lambda$chat$0(GeminiChatLanguageModel.java:80)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at io.quarkiverse.langchain4j.gemini.common.GeminiChatLanguageModel.chat(GeminiChatLanguageModel.java:78)
	at dev.langchain4j.model.chat.ChatModel_CAOdzSz_JXOmbdPru8SBVdBro64_Synthetic_ClientProxy.chat(Unknown Source)

Added Null Check

@KaiSuchomel KaiSuchomel requested a review from a team as a code owner August 25, 2025 13:31
@KaiSuchomel KaiSuchomel changed the title fix: prevent NPE in case of null temperature/topP Prevent NPE in case of null temperature/topP Aug 25, 2025

This comment has been minimized.

This comment has been minimized.

Copy link

quarkus-bot bot commented Aug 25, 2025

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit 25cf238.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 50196a4 into quarkiverse:main Aug 25, 2025
151 of 155 checks passed
@KaiSuchomel
Copy link
Contributor Author

KaiSuchomel commented Aug 26, 2025

@geoand @jmartisk When will the new/next release be available?

@geoand
Copy link
Collaborator

geoand commented Aug 26, 2025

Likely some time this week

@geoand geoand added triage/backport-1.1 Label to be added to PRs that should be considered for backporting to 1.1 and removed triage/backport-1.1 Label to be added to PRs that should be considered for backporting to 1.1 labels Aug 26, 2025
@geoand
Copy link
Collaborator

geoand commented Aug 26, 2025

1.1.2 was released and contains this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants