Adapt samples to work with platform #1742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fedinskiy
commented
Sep 2, 2025
fedinskiy
commented
- Take versions of dependencies from Quarkus Platform BOMs
- Use platform-dependent version of quarkus-maven-plugin (required for work with RHBQ)
- Drop deployment dependencies (it doesn't look like their usage affects the size of the build at all)
- Take versions of dependencies from Quarkus BOMs - Use platfrom-dependent version of qaurkus-maven-plugin (required for work with RHBQ) - Drop deployment dependecies (it doesn't look like their usage affects the size of the build at all)
fedinskiy
force-pushed
the
platform-in-samples
branch
from
d2cfc84 to
d3bbfc0
Compare
|
I actually think that this change is not helpful for people coming to Quarkus LangChain4j for the samples. |
|
@geoand could you elaborate? These poms are now much closer to ones generated by quarkus cli or maven plugin, and so are less surprising for users. |
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs |
|---|---|---|---|---|---|
| ❌ | JVM tests - samples - Java 17 | Run tests of samples with JDK 17 |
Logs | Raw logs | |
| ❌ | JVM tests - samples - Java 21 | Run tests of samples with JDK 21 |
Logs | Raw logs | |
| ❌ | JVM tests - samples - Java 24 | Run tests of samples with JDK 24 |
Logs | Raw logs |
|
I don't want the samples to be tied to the latest version on the Quarkus platform - I want them to always reflect the latest Quarkus LangChain4j version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.