Skip to content

Llama and Llama3: Move runtime configuration to RuntimeValue in the Recorder constructor #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2025
Merged

Llama and Llama3: Move runtime configuration to RuntimeValue in the Recorder constructor #1745

merged 3 commits into from
Sep 4, 2025

Conversation

gastaldi
Copy link
Member

@gastaldi gastaldi commented Sep 4, 2025 •
edited
Loading

  • Bump to Quarkus 3.20.2.2
  • Refactor Llama3 configuration and model management logic
  • Refactor Llama recorder

@gastaldi
Bump to Quarkus 3.20.2.2
9de766c
@gastaldi
Refactor Llama3 configuration and model management logic
5bd711d 
- Refactor configuration handling by transitioning to `RuntimeValue` wrappers, simplifying injection patterns and method signatures.
- Improve model deployment workflow with enhanced logging, error handling, and static initialization for native builds.
- Streamline progress reporting and user updates during model download for better performance and readability.
@gastaldi gastaldi requested a review from a team as a code owner September 4, 2025 14:51
@gastaldi gastaldi changed the title Llama3: Move runtime configuration to RuntimeValue in the Recorder constructor Llama and Llama3: Move runtime configuration to RuntimeValue in the Recorder constructor Sep 4, 2025
geoand
geoand approved these changes Sep 4, 2025
View reviewed changes
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 4, 2025

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit aa55364.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 7cac118 into main Sep 4, 2025
80 checks passed
@geoand geoand deleted the runtime_fix branch September 4, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gastaldi @geoand