Added scratchpad to support old office formats#5
Conversation
gastaldi
left a comment
gastaldi
left a comment
There was a problem hiding this comment.
Fantastic! Thank you so much!
| void indexTransitiveDependencies(BuildProducer<IndexDependencyBuildItem> index) { | ||
| index.produce(new IndexDependencyBuildItem("org.apache.xmlbeans", "xmlbeans")); | ||
| index.produce(new IndexDependencyBuildItem("org.apache.poi", "poi-ooxml-full")); | ||
| index.produce(new IndexDependencyBuildItem("org.apache.poi", "poi-scratchpad")); |
There was a problem hiding this comment.
Depending on the size, I wonder if it should be a different extension.
There was a problem hiding this comment.
I was thinking if it would be possible to make support for different formats configurable with build time configuration? I believe quite some Quarkus features can be configured in such way...
For example scratchpad could be conditionally included? Or maybe even something more fine-grained, if this makes sense at all...
There was a problem hiding this comment.
I don't think that's possible without a separate extension
|
PR is failing with: Caused by: java.lang.NullPointerException
at org.apache.poi.poifs.filesystem.FileMagic.prepareToCheckMagic(FileMagic.java:222)
at org.apache.poi.hwpf.HWPFDocumentCore.verifyAndBuildPOIFS(HWPFDocumentCore.java:137)
at org.apache.poi.hwpf.HWPFDocument.<init>(HWPFDocument.java:223)
at io.quarkiverse.poi.it.POIResource.doc(POIResource.java:64) |
|
I will have a look. There is a bit of a struggle with native build on a mac due to awt… |
Yes, it's caused by: I've opened the following PRs as an attempt to workaround it: |
|
I created #9. Meanwhile, I'll merge this. Thank you! |
|
@all-contributors add @tpodg for code |
|
I've put up a pull request to add @tpodg! 🎉 |
3 participants
Added additional dependency on poi-scratchpad, which supports older MS Office formats (as .doc).