Skip to content

Remove Content-Encoding header when response is 204 #49880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

Remove Content-Encoding header when response is 204 #49880

merged 1 commit into from
Sep 4, 2025
+36 −0

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 4, 2025

@geoand geoand requested a review from gastaldi September 4, 2025 13:03
@quarkus-bot quarkus-bot bot added the area/rest label Sep 4, 2025
gastaldi
gastaldi approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. Wonder if other Content-* headers should be removed as well

@geoand
Copy link
Contributor Author

geoand commented Sep 4, 2025

Good point, I don't really know TBH

@gastaldi
Copy link
Contributor

gastaldi commented Sep 4, 2025

Sounds like we need to backport this fix too?

@geoand
Copy link
Contributor Author

geoand commented Sep 4, 2025

We could, but it's pretty minor TBH

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 4, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 705d7ed.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 08a65a9 into quarkusio:main Sep 4, 2025
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Sep 4, 2025
@geoand geoand deleted the #49879 branch September 5, 2025 06:58
@gsmet gsmet modified the milestones: 3.28 - main, 3.26.3 Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/rest kind/bugfix
Projects
None yet
Milestone
3.26.3
Development

Successfully merging this pull request may close these issues.

quarkus.http.enable-compression=true adds content-encoding gzip even for http 204 No content
3 participants
@geoand @gastaldi @gsmet