Skip to content

fix: avoid hanging terminal if older version is available #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

RobPasMue
Copy link
Contributor

Hi all! This is an issue we've encountered recently...

Quarto was already installed in a self-hosted runner (for various, undetermined reasons). We weren't aware of this and we were also using the quarto-action for setting up quarto. Anyway, it seems like we already had tinytex installed in our machine as well via quarto, but we had an old version... and quarto was prompting us for an update.

This is not possible on CI/CD and thus I would assume that some other users might be impacted by this. For CI/CD purposes, I think it's best if we just assume --no-prompt to be the standard =)

Leaving the PR for the maintainers to review! Happy to provide more feedback if needed

@RobPasMue
Copy link
Contributor Author

RobPasMue commented Dec 11, 2024

Pinging @cderv and @cscheid for review since they seem to be the main maintainers :)

@cderv
Copy link
Collaborator

cderv commented Dec 11, 2024

@RobPasMue no need to directly ping developers. We'll see the PR as we watch repo. So please avoid doing that. Especially when you opened the PR or issue. Thanks in advance !

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding that. I agree --no-prompt should be use here.

However, if you have set tinytex: true no that we won't check for an already installed version.

Our actions is meant mainly for Github Actions hosted runner. So when used on self hosted runner, probably some adaptation and non default configuration to make. Hopefully this is the only problem you'll encounter

@cderv cderv merged commit 8776aaf into quarto-dev:main Dec 11, 2024
@RobPasMue RobPasMue deleted the patch-1 branch December 11, 2024 13:07
@RobPasMue
Copy link
Contributor Author

Thanks for the review and the comments @cderv - much appreciated. Would it be possible to get the action patch released with this change?

@cderv
Copy link
Collaborator

cderv commented Dec 11, 2024

Sure. new version is out

@RobPasMue
Copy link
Contributor Author

Awesome, thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants