Improved (less aggressive) editor focus preservation behavior #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjallaire
commented
Apr 19, 2025
jjallaire
commented
- Don't preserve focus during render on save as this often ends up stealing focus from the terminal (which can lead to stray characters in documents).
- Don't preserve focus after revealing preview window (we already tell vscode to preserveFocus -- this used to be inconsistently respected but now seems to work properly).
- Don't preserve focus during render on save as this often ends up stealing focus from the terminal (which can lead to stray characters in document)s. - Don't preserve focus after revealing preview window (we already tell vscode to preserveFocus -- this used to be inconsistently respected but now seems to work properly)
juliasilge
approved these changes
Apr 19, 2025
There was a problem hiding this comment.
This is working well for me! It's a little bit of a bummer to not have the focus switch back to the editor, but I also have experienced that problem with stray characters and I agree that it is much worse than having the user need to handle the focus themselves. Maybe we can revisit this in the future to get back some of that focus preservation.
I updated the changelog in 863233b so this is good to merge now. ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.