Skip to content

Turn off visual mode completions in Positron #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2025

Conversation

juliasilge
Copy link
Collaborator

@juliasilge juliasilge commented May 18, 2025

Addresses posit-dev/positron#7201

This PR turns off the completions in the custom visual editor in Positron. I think the completions are similarly pretty bad in the visual editor in VS Code, but to be conservative, this PR only turns them off in Positron. If you look in that codeview.ts file, I think the completions are the only thing we really want to turn off for now, to avoid the truly heinous experience people are getting currently.

This does not address posit-dev/positron#7709 because the problem there is that the statement range provider isn't getting piped through to the visual editor at all; there is nothing to turn off there. The other not-so-great experiences we outline in posit-dev/positron#1805 are because we are similarly not providing something (for example, hover help), not because we are providing something badly that we can temporarily turn off.

QA Notes

  • You should get completions in the YAML headers of .qmd, in both visual and source
  • You should still get completions in source editing, the same that you would get in a regular .py or .R file
  • You should now not get completions in a visual editor

Copy link
Collaborator

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #712 first, which seems like a nice improvement in the clarity of this function. No behavior changes there.

Before this PR:

Screenshot 2025-05-19 at 12 49 52 PM

After this PR:

Screenshot 2025-05-19 at 12 50 01 PM

…de-in-positron-davis

Clarify that this is just a series of potential early exits
@juliasilge juliasilge merged commit 8ad5731 into main May 19, 2025
1 check passed
@juliasilge juliasilge deleted the no-completions-in-visual-mode-in-positron branch May 22, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants