Turn off visual mode completions in Positron #710
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#7201
This PR turns off the completions in the custom visual editor in Positron. I think the completions are similarly pretty bad in the visual editor in VS Code, but to be conservative, this PR only turns them off in Positron. If you look in that
codeview.ts
file, I think the completions are the only thing we really want to turn off for now, to avoid the truly heinous experience people are getting currently.This does not address posit-dev/positron#7709 because the problem there is that the statement range provider isn't getting piped through to the visual editor at all; there is nothing to turn off there. The other not-so-great experiences we outline in posit-dev/positron#1805 are because we are similarly not providing something (for example, hover help), not because we are providing something badly that we can temporarily turn off.
QA Notes
.qmd
, in both visual and source.py
or.R
file