-
Notifications
You must be signed in to change notification settings - Fork 19
Issue #4: timestamp field #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8720b14
to
42d506c
Compare
6ef8e3f
to
cd95e27
Compare
fbd2a64
to
9834af7
Compare
9834af7
to
715edb7
Compare
4e7a873
to
376441f
Compare
376441f
to
ae3d633
Compare
be2fd3f
to
a76afb5
Compare
dc51b84
to
2141af1
Compare
2141af1
to
022d331
Compare
fmassot
reviewed
Dec 16, 2023
c2e2ff4
to
89226d0
Compare
89226d0
to
bc63730
Compare
fmassot
reviewed
Dec 27, 2023
fmassot
requested changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good, I did not find issues while testing it.
Can we add a few tests on the backend side? This will really help to sleep at night :)
68e2b2f
to
71806e8
Compare
71806e8
to
26c22f5
Compare
26c22f5
to
1d64540
Compare
It's done :) |
fmassot
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.