Add SnippetGenerator for highlighting [fixed] #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SnippetGenerator for getting highlighted snippets from documents
The pull-request had few other improvements / changes in schemabuilder. These changes were causing additional errors. Some of these changes were already implemented in the master branch.
Sidhant29
pushed a commit
to Sidhant29/tantivy-py
that referenced
this pull request
Apr 17, 2023
cjrh
added a commit
that referenced
this pull request
Sep 13, 2023
Co-authored-by: Justin Greene <[email protected]> Co-authored-by: Paul Masurel <[email protected]> Co-authored-by: Pratyush Mittal <[email protected]> Co-authored-by: mukeshsahnis <[email protected]>
Collaborator
|
Many thanks @pratyushmittal , after your work has eventually been merged in #122 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this is built on @jgreene's pull-request: #36
This one fixes conflicts and changes since the last pull-request.
I have tested it locally. It compiles and works fine without errors.
All credits to @jgreene for a fantastic update.