Skip to content

Conversation

@Sidhant29
Copy link
Collaborator

@Sidhant29 Sidhant29 commented Jul 2, 2023

This Pr reflects the API changes observed from tantivy 0.19.2 to 0.20.1.

  • The numeric_options interface has changes from requiring a str param of 'single', 'multivalued', to just a bool param. Fast fields hence support only 'single' mode.
  • The order_by_u64 method now accepts a 'str' field name, instead of the entire field object.
  • The schema.get_field method returns a Result instead of an option.

@Sidhant29 Sidhant29 requested review from ChillFish8, cjrh and wallies July 2, 2023 06:38
@cjrh
Copy link
Collaborator

cjrh commented Jul 2, 2023

I had a look too, same question as @adamreichold why did the test change?

Resolved. We figured out it was the writer heap setting. More info in the other resolved comment on this PR.

@wallies wallies merged commit a266f41 into quickwit-oss:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants