Added seek_doc to weight #2785
Open
Added seek_doc to weight #2785
+659
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton-dd
force-pushed
the
paul.masurel/skip-first-doc-on-intersection
branch
from
3bc26fa to
4800401
Compare
fulmicoton-dd
commented
Dec 30, 2025
fulmicoton-dd
force-pushed
the
paul.masurel/skip-first-doc-on-intersection
branch
5 times, most recently
from
eac4c95 to
1898828
Compare
fulmicoton-dd
force-pushed
the
paul.masurel/skip-first-doc-on-intersection
branch
7 times, most recently
from
20ef4f2 to
f98ba14
Compare
tantivy requires Scorer to be positioned on a DocId at all time. This decision is not performance neutral. When we have an intersection of a heavy DocSet with a lighter one forcing the positioning of the first doc is needlessly expensive. This PR fixes this by introducing a seek_doc parameter in the weight function. Weights may skip over documents when they create the Scorer.
fulmicoton-dd
force-pushed
the
paul.masurel/skip-first-doc-on-intersection
branch
from
f98ba14 to
98be1a5
Compare
fulmicoton-dd
force-pushed
the
paul.masurel/skip-first-doc-on-intersection
branch
from
d954b74 to
601541e
Compare
PSeitz
reviewed
Jan 2, 2026
| } | ||
|
|
||
| /// Returns a priority number used to sort weights when running an | ||
| /// intersection. |
Collaborator
There was a problem hiding this comment.
We should add a comment here what higher or lower numbers mean
PSeitz
reviewed
Jan 2, 2026
fulmicoton-dd
force-pushed
the
paul.masurel/skip-first-doc-on-intersection
branch
from
b3db43b to
d210a30
Compare
fulmicoton-dd
force-pushed
the
paul.masurel/skip-first-doc-on-intersection
branch
from
d210a30 to
a5dc888
Compare
PSeitz
reviewed
Jan 6, 2026
| /// Creates a Segment Postings from a | ||
| /// - `BlockSegmentPostings`, | ||
| /// - a position reader | ||
| /// - a target document to seek to |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// - a target document to seek to | |
| /// - a target document to seek to within the passed block |
not sure if that's correct (the comment and variable name don't match)
PSeitz
reviewed
Jan 6, 2026
| let Some(term_info) = self.get_term_info(term)? else { | ||
| return Ok(None); | ||
| }; | ||
| let block_postings_not_loaded = |
Collaborator
There was a problem hiding this comment.
Suggested change
| let block_postings_not_loaded = | |
| let block_postings = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.