fix: clear stale skills before syncing globals on container spawn#1320
Open
akasha-scheuermann wants to merge 2 commits intoqwibitai:mainfrom
Open
fix: clear stale skills before syncing globals on container spawn#1320akasha-scheuermann wants to merge 2 commits intoqwibitai:mainfrom
akasha-scheuermann wants to merge 2 commits intoqwibitai:mainfrom
Conversation
When a skill is removed from container/skills/, the old copy persists in each group's .claude/skills/ indefinitely. Wipe the destination directory before re-copying so deleted skills are properly cleaned up. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
akasha-scheuermann
requested review from
gabi-simons and
gavrielc
as code owners
When a container crashes after messages are piped to it, those messages are lost — the cursor has already advanced past them. This adds a rollback cursor that persists the pre-pipe cursor position so messages can be re-fetched on crash recovery. - Save cursor_before_pipe in router_state before advancing - Clear rollback cursor on successful output delivery - Roll back cursor on crash recovery (only if container is dead) - Clear all rollback cursors on clean shutdown (containers detached) - Add GroupQueue.isActive() to check container liveness during recovery Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
When a skill is removed from
container/skills/, the old copy persists in each group's.claude/skills/indefinitely. Each container spawn copies new skills on top but never removes ones that no longer exist.Fix: wipe the skills destination directory before re-copying globals, so deleted skills are properly cleaned up.
Changes:
rmSync(skillsDst)before the global skills copy loop inbuildVolumeMounts