feat: add shimmer typing indicator to Slack channel skill#653
feat: add shimmer typing indicator to Slack channel skill#653takeru wants to merge 2 commits intoqwibitai:mainfrom
Conversation
Use Slack's Agents & Assistants API (assistant.threads.setStatus) to show a shimmer effect on the bot's name while processing. Requires enabling "Agents & AI Apps" in the Slack app settings for the assistant:write scope. Silently degrades when the scope is missing or in non-DM channels. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0cf763427d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const threadTs = this.lastUserMessageTs.get(jid); | ||
| if (!threadTs) return; |
There was a problem hiding this comment.
setTyping(false) always reads the current value from lastUserMessageTs, but that map is overwritten on every new user message in the channel. If another user message arrives while the agent is still processing, the false call will clear a different thread_ts than the one used for setTyping(true), leaving the original thread stuck showing “is thinking…”.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed — setTyping(true) now pins the thread_ts into an activeTypingTs map, and setTyping(false) reads from there instead of lastUserMessageTs. This ensures the correct thread is cleared even if new messages arrive during processing.
| if (!isBotMessage) { | ||
| this.lastUserMessageTs.set(jid, msg.ts); | ||
| } |
There was a problem hiding this comment.
The handler stores msg.ts for typing status, but for replies inside an existing Slack thread the thread identifier is msg.thread_ts (with msg.ts being only the reply’s own timestamp). Using msg.ts causes assistant.threads.setStatus to target the wrong thread context for follow-up replies, so the shimmer indicator silently fails in threaded conversations.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed — now using msg.thread_ts ?? msg.ts so threaded replies correctly target the thread root timestamp.
- Store the thread_ts used for setTyping(true) so that setTyping(false) always clears the correct thread, even if new messages arrive mid-processing. - Use msg.thread_ts (thread root) instead of msg.ts for threaded replies, since assistant.threads.setStatus targets threads by their root timestamp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Shimmer typing indicator for Slack — that's a nice touch for UX. Small and self-contained. @gavrielc should be quick to review. |
Andy-NanoClaw-AI
added
PR: Feature
Andy-NanoClaw-AI
added
Status: Blocked
Slack replies now go into threads instead of the channel root. When SLACK_ALWAYS_REPLY_IN_THREAD=true, root messages start a new thread; threaded replies respond in the same thread; DMs reply directly. Also adds shimmer typing indicator via Slack's assistant.threads.setStatus API (requires assistant:write scope, silent no-op without it). Opts out of setup/update diagnostics telemetry. Based on upstream PRs qwibitai#682 and qwibitai#653. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 participants
Summary
assistant.threads.setStatus) in the add-slack skill to show a shimmer/typing indicator while the bot processes messagesassistant:writescope is missing or when used outside of DM threadsHow it works
When the orchestrator calls
setTyping(jid, true), the Slack channel now callsassistant.threads.setStatuswithstatus: 'is thinking...'on the thread of the last user message. When called withfalse, it clears the status by sending an empty string. Bot messages are excluded from timestamp tracking so the indicator only activates in response to real user messages.Slack-side configuration
To enable the shimmer typing indicator:
assistant:writescope needed forassistant.threads.setStatusIf the scope is not configured, the feature silently no-ops -- no errors will be thrown.
Files changed
.claude/skills/add-slack/add/src/channels/slack.ts-- Implementation.claude/skills/add-slack/add/src/channels/slack.test.ts-- Tests (5 new test cases)Test plan
setTyping(jid, true)callsassistant.threads.setStatuswith'is thinking...'statussetTyping(jid, false)clears the status with empty string🤖 Generated with Claude Code