Skip to content

spaces_inside_linter marker is incorrect for multi-line expressions #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelChirico opened this issue Jun 1, 2022 · 1 comment · Fixed by #1351
Closed

spaces_inside_linter marker is incorrect for multi-line expressions #1343

MichaelChirico opened this issue Jun 1, 2022 · 1 comment · Fixed by #1351
Milestone
3.0.0

Comments

@MichaelChirico
Copy link
Collaborator

We should anchor to the second line for lints on the closing parenthesis:

lint("(x &
y )", spaces_inside_linter())
# <text>:1:2: style: Do not place spaces before parentheses.
# (x &
#  ^~~
@MichaelChirico MichaelChirico added this to the 3.0.0 milestone Jun 1, 2022
@MichaelChirico MichaelChirico mentioned this issue Jun 2, 2022
Closed
21 tasks
@AshesITR
Copy link
Collaborator

AshesITR commented Jun 2, 2022

I wonder, isn't the y token starting on line2?

@MichaelChirico MichaelChirico mentioned this issue Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

anchor to right paren to ensure better lint markers in spaces_inside_linter r-lib/lintr
2 participants
@AshesITR @MichaelChirico