Release lintr 3.0.0 #824

AshesITR · 2021-07-02T17:09:43Z

MichaelChirico · 2021-07-02T17:40:05Z

Aside: I can tell I've been working on translations too much lately that I read "Polish NEWS" as "🇵🇱 NEWS"

AshesITR · 2021-07-02T17:44:39Z

Feel free to add or remove TODOs, I just used usethis::use_release_issue() to not forget anything.

AshesITR · 2021-07-03T07:14:43Z

I've started a full revdepcheck, will upload the results later.

Edit: I'm having trouble with some packages producing unintelligible error messages.
Can anyone else see if they manage to complete revdepcheck on the 94 packages?

russHyde · 2021-07-07T07:52:23Z

Could you add @AshesITR , @MichaelChirico and @renkun-ken as authors in DESCRIPTION prior to release. You've done really great work on lintr over the past year.

lorenzwalthert · 2021-11-09T17:18:03Z

Any ETA on this?

eitsupi · 2022-03-19T16:06:24Z

Thank you for your continued development. I am wondering when a new release is planned.
(It seems that most of what's on the to-do list has been accomplished.)

MichaelChirico · 2022-03-21T00:16:11Z

I think #962 is the main blocker before going back into release cycle (checking revdeps, tidying NEWS, etc). @AshesITR any other thoughts?

MichaelChirico · 2022-04-14T06:11:24Z

OK, just took another pass at triaging issues for this release. I am pretty happy with what'll be included based on the current milestone. @AshesITR feel free to update. 23 issues left, >1/2 of which have corresponding PRs, a few more are meta-issues related to the release itself. I think we're pretty close.

MichaelChirico · 2022-05-19T20:34:50Z

Looking at the milestone, I think we're pretty much at "code freeze" stage -- shall I put out an announcement requesting early testing? Maybe after #1140?

AshesITR · 2022-05-19T20:35:35Z

SGTM

MichaelChirico · 2022-05-22T01:16:01Z

Noting here that Hadley offered to host a release blog post on the tidyverse blog:

https://twitter.com/hadleywickham/status/1528081727259824128

MichaelChirico · 2022-06-02T00:47:49Z

Finally got latest dev working internally and did a full run of 2.0.1 vs. roughly aec989e (I'll just call it 3.0) and am comparing. Note that ~most lints at our HEAD were already cleaned, so the baseline is relatively low. here's a rough summary of the observed changes:

~1% of lints found in 2.0.1 are gone in 3.0
- ✅ about half are from ignoring trailing whitespace in strings in trailing_whitespace_linter
- ✅ about 13% are from paren_brace_linter false positives matching inside strings (mainly regexes/CSS)
- ✅ about 10% are from T_and_F_symbol_linter false positives like foo$T
- ✅ about 10% are from commas_linter false positives like switch(x, a = , b = 2)
- ❌ about 13% are from false negatives in infix_spaces_linter: New false negatives in infix_spaces_linter #1342
- ❌ about 10% are from mismatch in metadata for spaces_inside_linter: spaces_inside_linter marker is incorrect for multi-line expressions #1343
~25% of lints found in 3.0 were not there in 2.0.1
- ✅ about 10% are on the new missing_argument_linter; a decent number would fit under Add a parameter allow_trailing to missing_argument_linter() #1152
- ✅ about 10% are thanks to improvements in fixed_regex_linter, e.g. when named arguments are given
- ✅ about 3% are thanks to improvements in infix_spaces_linter, e.g. function(x=1), y~x, etc.
- ✅ about 1% are additions to paste_linter for paste0(sep = .)
- ✅ about 1% are new hits on completely blank lines for trailing_whitespace_linter
- ✅ about 1% are thanks to improvements in conjunct_test_linter to include assert_that
- ✅ about 1% are thanks to improvements in trailing_blank_lines_linter to catch missing terminal newlines
- ✅ about 1% are thanks to improvements in function_left_parentheses_linter to catch usages across >1 line like foo\n()
- ✅ about 1% are thanks to selectively disabling linters revealing code that was in #nolint regions but violated unrelated rules
- ✅ residual good things: new hits in package_hooks_linter, expect_null_linter, inner_combine_linter, paren_body_linter, ...
- 🧐 about 15% are new hits on brace_linter, e.g. function(x) {x[1]}, but some seem OK: Allow { } or {} in brace_linter independently of allow_single_line? #1346
- 🧐 about 15% are on the new duplicate_argument_linter; a lot seem due to dplyr::mutate(): duplicate_argument_linter should skip on mutate() calls #1345
- ❌ about 33% are from improvements to unneeded_concatenation_linter that probably go too far: unneeded_concatenation_linter() can throw on valid usages #1344

MichaelChirico · 2022-06-02T00:49:15Z

oh, also, the full run took about 20% less time overall. I was working more during the slower run, but not enough to make that big a difference. there's a lot of other overhead to our system that means this figure probably doesn't generalize well, but if anything, I'd guess the typical user will see >20% improvement.

jimhester · 2022-06-12T14:28:19Z

latest CRAN communication

package lintr is now scheduled for archival on 2022-06-26, and
archiving this will necessitate also archiving its CRAN strong reverse
dependencies.

from looking at the above this shouldn’t be hard to meet, but we should get this release out sooner rather than later.

AshesITR · 2022-06-12T21:48:04Z

@jimhester I think we're ready for the final steps. Since you are the maintainer, you'll receive the mails from devtools::check_win_devel() et al. Do you want to start them yourself?

I'm running a final revdepcheck to get #832 done and would leave the rest to you if that's fine?

jimhester · 2022-06-13T14:20:58Z

Ok, I have finished up the last few things and submitted the package, will update this once it is accepted.

MichaelChirico · 2022-06-14T05:09:40Z

I see us on CRAN! thanks Jim!

Leaving this open while our checks are pending. Only two finished thus far.

bersbersbers · 2022-06-14T05:12:58Z

Congratulations!

russHyde · 2022-06-14T11:47:14Z

Looks like it's out in the wild now

MichaelChirico · 2022-06-14T23:13:05Z

Hmm looks like we are warning on oldrel:

https://www.r-project.org/nosvn/R.check/r-oldrel-macos-arm64/lintr-00check.html

checking examples ... [1s/1s] WARNING
Found the following significant warnings:

  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
  Warning: 'all.equal.default(<function>)' is deprecated.
Deprecated functions may be defunct as soon as of the next release of
R.
See ?Deprecated.

This despite not warning on GHA: https://github.com/r-lib/lintr/runs/6886795725?check_suite_focus=true 😭

Must be due to this:

lintr/R/with.R

Line 76 in 5a0b54e

#' all.equal(linters_with_defaults(), linters_with_tags("default"))

jimhester · 2022-06-15T14:56:46Z

Seems like the oldrel-mac is lagging, it is only 4.1.1-patched for arm, 4.1.2 for x86, but 4.1.3 is released and is what we are testing against on the CI. (Also note the windows-oldrel on CRAN is OK)

wch/r-source@3506de0 is the relevant commit, which presumably was backported to 4.1.3, but not earlier patch releases.

I don't think we need to do anything about that warning.

MichaelChirico · 2022-06-15T15:13:59Z

👍 sounds like we're unlikely to get archived then.

I'm still wondering if we shouldn't revisit the S3 class of Linter() output

MichaelChirico · 2022-06-20T02:06:17Z

looks like we're erroring on 3.0.0 -- I can't make heads or tails of what's wrong though:

https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/lintr-00check.html

AshesITR · 2022-06-20T05:09:08Z

Looks to me as if the fixes we do might no longer be necessary in 4.3.0.
I'll try to update my r-devel and take a look.

AshesITR · 2022-06-20T09:01:09Z

I fail to reproduce on R-devel @ Windows 10.

Edit: https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/lintr-00check.html works fine.
Seems related to the session charset (ISO-8859-15).

MichaelChirico · 2022-06-21T17:13:49Z

I'm also seeing a timeout on two Windows flavors:

https://cran.r-project.org/web/checks/check_results_lintr.html

Check process probably crashed or hung up for 20 minutes ... killed
Most likely this happened in the example checks (?),
if not, ignore the following last lines of example output:
>
> ### ** Examples
>
> ## Not run:
> ##D # use the default set of linters
> ##D lintr::use_lintr()
> ##D # or try all linters
> ##D lintr::use_lintr(type = "full")
> ##D
> ##D # then
> ##D lintr::lint_dir()
> ## End(Not run)
>
>
>
> ### * <FOOTER>
> ###
> cleanEx()
> options(digits = 7L)
> base::cat("Time elapsed: ", proc.time() - base::get("ptime", pos = 'CheckExEnv'),"\n")
Time elapsed: 6.7 1.79 9.59 NA NA
> grDevices::dev.off()
null device
          1
> ###
> ### Local variables: ***
> ### mode: outline-minor ***
> ### outline-regexp: "\\(> \\)?### [*]+" ***
> ### End: ***
> quit('no')
======== End of example output (where/before crash/hang up occured ?) ========

Not sure what to make of that.

jimhester · 2022-06-21T18:08:47Z

We could add something like this on the CI, to test in non-UTF-8 locales

https://github.com/r-lib/fs/blob/e10022f2df4571a8598a4caec4929d4b133566d9/.github/workflows/R-CMD-check.yaml#L37-L42

Hopefully that would reproduce the issue seen on that CRAN flavor.

MichaelChirico · 2022-07-25T06:41:20Z

Add link to blog post in pkgdown news menu

what does that entail, exactly 😅

IndrajeetPatil · 2022-07-25T06:45:34Z

I think it means adding the following to the _pkgdown.yml:

news:
  releases:
  - text: "Version 3.0.0"
    href: https://www.tidyverse.org/blog/2022/07/lintr-3-0-0/

MichaelChirico · 2022-07-27T02:06:35Z

With #1470 the blog post link is finally on the site; closing this

AshesITR added this to the 3.0.0 milestone Jul 2, 2021

MichaelChirico mentioned this issue Jul 2, 2021

[Discussion] lintr 3.0.0 release? #718

Closed

AshesITR mentioned this issue Jul 2, 2021

Add new linters to README.md; remove LazyData from DESCRIPTION #826

Merged

renkun-ken mentioned this issue Jul 3, 2021

Imports the upcoming lintr 3.0.0 REditorSupport/languageserver#449

Open

AshesITR mentioned this issue Jul 8, 2021

Add @renkun-ken, @MichaelChirico and @AshesITR to Authors #831

Merged

MichaelChirico mentioned this issue Apr 28, 2022

Change deprecation warnings for version 2.0.1.9001 to version 3.0.0 #835

Closed

MichaelChirico mentioned this issue Jun 6, 2022

Draft: Release blog post #1364

Closed

AshesITR mentioned this issue Jun 23, 2022

Add CI test with non-english locale #667

Closed

IndrajeetPatil mentioned this issue Jul 25, 2022

Add blog post to the website #1470

Merged

MichaelChirico closed this as completed Jul 27, 2022

Release lintr 3.0.0 #824

Release lintr 3.0.0 #824

Comments

AshesITR commented Jul 2, 2021 • edited by MichaelChirico Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MichaelChirico commented Jul 2, 2021

Uh oh!

AshesITR commented Jul 2, 2021

Uh oh!

AshesITR commented Jul 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

russHyde commented Jul 7, 2021

Uh oh!

lorenzwalthert commented Nov 9, 2021

Uh oh!

eitsupi commented Mar 19, 2022

Uh oh!

MichaelChirico commented Mar 21, 2022

Uh oh!

MichaelChirico commented Apr 14, 2022

Uh oh!

MichaelChirico commented May 19, 2022

Uh oh!

AshesITR commented May 19, 2022

Uh oh!

MichaelChirico commented May 22, 2022

Uh oh!

MichaelChirico commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelChirico commented Jun 2, 2022

Uh oh!

jimhester commented Jun 12, 2022

Uh oh!

AshesITR commented Jun 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jimhester commented Jun 13, 2022

Uh oh!

MichaelChirico commented Jun 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bersbersbers commented Jun 14, 2022

Uh oh!

russHyde commented Jun 14, 2022

Uh oh!

MichaelChirico commented Jun 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jimhester commented Jun 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelChirico commented Jun 15, 2022

Uh oh!

MichaelChirico commented Jun 20, 2022

Uh oh!

AshesITR commented Jun 20, 2022

Uh oh!

AshesITR commented Jun 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelChirico commented Jun 21, 2022

Uh oh!

jimhester commented Jun 21, 2022

Uh oh!

MichaelChirico commented Jul 25, 2022

Uh oh!

IndrajeetPatil commented Jul 25, 2022

Uh oh!

MichaelChirico commented Jul 27, 2022

Uh oh!

AshesITR commented Jul 2, 2021 •

edited by MichaelChirico

Loading

AshesITR commented Jul 3, 2021 •

edited

Loading

MichaelChirico commented Jun 2, 2022 •

edited

Loading

AshesITR commented Jun 12, 2022 •

edited

Loading

MichaelChirico commented Jun 14, 2022 •

edited

Loading

MichaelChirico commented Jun 14, 2022 •

edited

Loading

jimhester commented Jun 15, 2022 •

edited

Loading

AshesITR commented Jun 20, 2022 •

edited

Loading