Skip to content

Change deprecation warnings for version 2.0.1.9001 to version 3.0.0 #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AshesITR opened this issue Jul 9, 2021 · 2 comments · Fixed by #836
Closed

Change deprecation warnings for version 2.0.1.9001 to version 3.0.0 #835

AshesITR opened this issue Jul 9, 2021 · 2 comments · Fixed by #836
Milestone
3.0.0

Comments

@AshesITR
Copy link
Collaborator

AshesITR commented Jul 9, 2021

No description provided.

@AshesITR AshesITR mentioned this issue Jul 9, 2021
Closed
21 tasks
AshesITR added a commit that referenced this issue Jul 9, 2021
@AshesITR
change deprecated versions from 2.0.1.9001 to 3.0.0
8f481bf 
fixes #835
@AshesITR AshesITR mentioned this issue Jul 9, 2021
Merged
@MichaelChirico MichaelChirico added this to the 3.0.0 milestone Mar 22, 2022
@MichaelChirico
Copy link
Collaborator

Changed the task in #824 to just be the title of this issue, and closing this one.

The thinking is, that update should be done with very precise "timing". Ideally no one sees 3.0.0 as the deprecated version while the DESCRIPTION version is <3.0.0. But 3.0.0 in the DESCRIPTION should be released to CRAN before GitHub.

In my experience that means keeping a release branch that's not merged to master until any back-and-forth with CRAN is complete and 3.0.0 actually hits CRAN servers.

To me, then, it makes more sense to track this issue as a bullet within the release issue alone, since this one won't be closed by a PR to master, only by a commit to the release branch.

Happy to re-open if I'm misunderstanding.

@AshesITR
Copy link
Collaborator Author

As discussed, I've updated #836 to include usethis::use_version("major").

jimhester added a commit that referenced this issue Jun 13, 2022
@AshesITR @MichaelChirico @jimhester
Version from 2.0.1.9001 to 3.0.0 (#836)
a9a6e34 
* change deprecated versions from 2.0.1.9001 to 3.0.0

fixes #835

* typo in NEWS (#1367)

* Rename old master branch to main in .dev/compare_branches (#1372)

* Deprecate find col (#1374)

* first pass -- scorched earth

* deprecate instead

* whitespace

* NEWS

Co-authored-by: AshesITR <[email protected]>

* Another round of NEWS polishing (#1370)

* add reasoning to "return" removal

* mention old argument still works

* combine+clarify some brace_linter items, add attributions

* consistent capitalization, clarifications

* finish pass for consistent capitalizatoin

* grammar

* move object_name bullet with others; clarify cyclocomp bullet

* mention CRAN policy re: cache directory

* more consistently reference only the issue (not PR) #s

* consistent capitalization in my GH username

* missing item for any_duplicated_linter

* improve description of system_file_linter

* clarify strings_as_factors_linter, more grammar

* more quantification of package speed-ups; more clarirfication

* more removing redundant issue references; reorg bullet for get_source_expressions

* clarification, remove redundant issue refs

* move another object_name_linter bullet up

* move extraction_operator item to "features" not bugs

* trailing whitespace

* trailing whitespace

* feedback

* lead with Deprecated

* wording for object_usage

* de-lint (#1378)

* de-lint

* tidyverse style, missing space

Co-authored-by: Michael Chirico <[email protected]>

* add tag "executing" to linters that call eval() or loadNamespace() on arbitrary input (#1383)

* benchmarking in .dev/compare_branches (#1375)

* skeleton for new --benchmark parameter

* incredibly hacky (but working on main at least) tracing approach

* Rename old master branch to main in .dev/compare_branches

* tweaks

* run .Last() even interactively

* debugging complete! works on main

* handle --branch=$TAG

* help mentions tag; git_branch_checkout doesnt work

* need to git reset

* robustly get linter call

* cant rely on ~recent internal helper for encoding

* remove remotes from temp repo

* handle odd case of line_length_linter, muffle newline warnings

* warn with tag names, not hashes

* implement _all_ option for linters, skip more noisy warnings

* fix default handling; simplify encoding test; correct branch-specific timings

* combine timings, save output

* save in wide format instead

* comment

* correct message

* add a TODO

* sum timing across expressions in output

* correct data.table imports

* refactor: use more helpers

* consolidate more

* another helper

* more refactoring... pray this works

* tweaks go get working

* correct handling of timing output

* add a TODO

* clarify TODO

* correct data.table imports again

* more nesting!

* one more helper

* remove debugger

* simplify warning message match

Co-authored-by: AshesITR <[email protected]>

* Polish news (#1384)

* consistent formatting

* sort bullets alphabetically

* add `allow_trailing = FALSE` to `missing_argument_linter()` (#1385)

* update deprecations

* usethis::use_version("major")

* update reference checkstyle.xml

Co-authored-by: Michael Chirico <[email protected]>
Co-authored-by: Michael Chirico <[email protected]>
Co-authored-by: Jim Hester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Version from 2.0.1.9001 to 3.0.0 r-lib/lintr
2 participants
@AshesITR @MichaelChirico