Skip to content

Add new linters to README.md; remove LazyData from DESCRIPTION #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 2, 2021

Conversation

AshesITR
Copy link
Collaborator

@AshesITR AshesITR commented Jul 2, 2021

fixes #825 and #827

@MichaelChirico
Copy link
Collaborator

recommend adding a note to do this before release in a document in .dev/

@AshesITR
Copy link
Collaborator Author

AshesITR commented Jul 2, 2021

Nice idea. Looking at the source code of usethis::use_release_issue() it seems one can define a function release_bullets within the package to automagically add it to the auto-generated issue.

use_release_issue() will include additional bullets if your package includes release_bullets() function which returns a character vector (and the package has been loaded with load_all()) (r-lib/usethis#941).

@AshesITR
Copy link
Collaborator Author

AshesITR commented Jul 2, 2021

I #nocov'd the function but locally tested.

You can try

devtools::load_all()
usethis:::release_checklist("3.0.0", TRUE)
#>  [1] "Prepare for release:"                                                                                  
#>  [2] ""                                                                                                      
#>  [3] "* [ ] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_lintr.html)"
#>  [4] "* [ ] [Polish NEWS](https://style.tidyverse.org/news.html#news-release)"                               
#>  [5] "* [ ] [`urlchecker::url_check()`](https://github.com/r-lib/urlchecker)"                                
#>  [6] "* [ ] `devtools::check(remote = TRUE, manual = TRUE)`"                                                 
#>  [7] "* [ ] `devtools::check_win_devel()`"                                                                   
#>  [8] "* [ ] `rhub::check_for_cran()`"                                                                        
#>  [9] "* [ ] `revdepcheck::revdep_check(num_workers = 4)`"                                                    
#> [10] "* [ ] Update `cran-comments.md`"                                                                       
#> [11] "* [ ] Draft blog post"                                                                                 
#> [12] "* [ ] Make sure README.md lists all available linters"                                                 
#> [13] ""                                                                                                      
#> [14] "Submit to CRAN:"                                                                                       
#> [15] ""                                                                                                      
# ...

@AshesITR AshesITR linked an issue Jul 2, 2021 that may be closed by this pull request
@AshesITR AshesITR changed the title Add new linters to README.md Add new linters to README.md; remove LazyData from DESCRIPTION Jul 2, 2021
@AshesITR AshesITR requested a review from MichaelChirico July 2, 2021 20:23
in addition to steering traffic away from datacamp-affiliated site, i think the rdrr links are better as "live" links instead of pointing to versions
@AshesITR AshesITR merged commit 81e3b46 into master Jul 2, 2021
@AshesITR AshesITR deleted the fix/825-readme-update branch July 2, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants