Skip to content

[Discussion] lintr 3.0.0 release? #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AshesITR opened this issue Jan 29, 2021 · 6 comments
Closed

[Discussion] lintr 3.0.0 release? #718

AshesITR opened this issue Jan 29, 2021 · 6 comments
Milestone

Comments

@AshesITR
Copy link
Collaborator

We've added a lot of new and exciting features to the current development version of lintr, to the point that some downstream users (including me) are using the github version because they need e.g. directory exclusions.

So I wonder, is it time for prepairing a new release of lintr?
I think the number of changes warrants a major version bump, so I suggest 3.0.0 to be the new version.

@MichaelChirico
Copy link
Collaborator

MichaelChirico commented Jan 29, 2021 via email

@AshesITR
Copy link
Collaborator Author

I looked at the current NEWS.md and found two changes, that might impact "off-label" usage of lintr:

  • exclusions are now relative to the .lintr file (they were relative to the caller wd before that):
    this could break code where a user conventionally calls e.g. lint_package() from outside the package and adapted the .lintr config to the previous (IMO quirky) behaviour
  • lints now have the linter name instead of the implementation name assigned:
    this could break contrived code where the names in linters are specified and later the Lint names used with the assumption that they are equal to the implementing functions, e.g. linters = list(a = line_length_linter()) produced lints from the line_length_linter while it now produces lints from the a linter. This seems unlikely to have relevance in practice

@MichaelChirico MichaelChirico added this to the 3.0.0 milestone Jan 31, 2021
@MichaelChirico
Copy link
Collaborator

Went ahead and created a milestone (3.0.0) to tag issues/PRs we'd like to close out for release.

@MichaelChirico
Copy link
Collaborator

LMK when we're about ready to freeze new features, I'll start a comparison of HEAD vs 2.0.1 on all CRAN

@AshesITR
Copy link
Collaborator Author

AshesITR commented Mar 8, 2021

I think the most important open issue is #720 atm. If we agree to settle on the current implementation, I would try finishing all open milestone:3.0.0 PRs and start with release preparations.

@MichaelChirico
Copy link
Collaborator

Closing this in favor of tracking release in #824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants