Skip to content

Draft: Release blog post #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from
Closed

Draft: Release blog post #1364

wants to merge 27 commits into from

Conversation

MichaelChirico
Copy link
Collaborator

Part of #824

Filing here to facilitate collaboration -- I've only got the first paragraph or so going.

@MichaelChirico MichaelChirico added this to the 3.0.0 milestone Jun 6, 2022
@MichaelChirico
Copy link
Collaborator Author

BTW, we won't merge this I guess. Just keep it in this branch for review and then pass the source along to Hadley to host it on the tidyverse blog. IIUC that should come after releasing to CRAN so that readers can install right away.

@MichaelChirico
Copy link
Collaborator Author

I was thinking about a section on the conversion to XPath logic / export of xml_nodes_to_lints(), WDYT @AshesITR, worthy of inclusion? Want to take a stab at it?

@AshesITR
Copy link
Collaborator

AshesITR commented Jun 7, 2022

I'd leave out the linter development stuff (including is_lint_level()) and move use_lintr() further up so new users can easily see how to try out the new package.
I think the audience will contain far more end users than linter developers.

Maybe include the snippets from README.md regarding using lintr?

@MichaelChirico
Copy link
Collaborator Author

Highlighted all the end-user-oriented linters in the beginning, WDYT?

minor updates
AshesITR
AshesITR previously approved these changes Jun 10, 2022
Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symbolic approval - the Blog post looks excellent now.
Thanks for the hard work!

@MichaelChirico
Copy link
Collaborator Author

great! @jimhester @russHyde @renkun-ken do you want to have a read through?

@MichaelChirico
Copy link
Collaborator Author

@hadley let us know anything else we should do / how we should proceed from here after 3.0.0 hits CRAN

@jimhester
Copy link
Member

jimhester commented Jun 10, 2022

This LGTM, thank you for writing it. Where were you planning on posting this, on tidyverse.org or elsewhere? Or just on the pkgdown site directly? For lintr 2.0.0 I had a post on my personal blog (https://www.jimhester.com/post/lintr-2-0-0/), but that doesn't seem the best place for this

@russHyde
Copy link
Collaborator

LGTM. Thanks so much for your hard work on lintr

@MichaelChirico
Copy link
Collaborator Author

This LGTM, thank you for writing it. Where were you planning on posting this, on tidyverse.org or elsewhere? Or just on the pkgdown site directly? For lintr 2.0.0 I had a post on my personal blog (https://www.jimhester.com/post/lintr-2-0-0/), but that doesn't seem the best place for this

Hadley had offered to host it on the tidyverse blog: https://twitter.com/hadleywickham/status/1528081727259824128

@MichaelChirico
Copy link
Collaborator Author

@jimhester I like the idea of including people who opened issues, not just those who changed code -- do you have a snippet handy for calculating that? Otherwise I guess it's just issues |> filter(dates_since(prev_release)) |> unique(OP) aided by {gh}?

@hadley
Copy link
Member

hadley commented Jun 10, 2022

@MichaelChirico usethis::use_tidy_thanks() might do what you need

@jimhester
Copy link
Member

@MichaelChirico thanks again for writing this up, I think it sounds great!

The next step would be to open this as a pull request on the tidyverse blog, at https://github.com/tidyverse/tidyverse.org.

I used https://unsplash.com/photos/NPPNHZK1U0s for the picture in the 2.0.0 release, you are welcome to reuse that, or pick another one as you prefer.

@AshesITR
Copy link
Collaborator

Dropping this here. Can we close this PR, @MichaelChirico?
tidyverse/tidyverse.org#584

@MichaelChirico
Copy link
Collaborator Author

I would leave it open as a TODO reminder for now

@MichaelChirico
Copy link
Collaborator Author

Closing -- tidyverse blog link for reference: https://www.tidyverse.org/blog/2022/07/lintr-3-0-0/

@MichaelChirico MichaelChirico deleted the release-blog branch October 9, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants