Skip to content

Polish NEWS #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #824
AshesITR opened this issue Jul 9, 2021 · 4 comments
Closed
Tracked by #824

Polish NEWS #833

AshesITR opened this issue Jul 9, 2021 · 4 comments
Milestone

Comments

@AshesITR
Copy link
Collaborator

AshesITR commented Jul 9, 2021

No description provided.

This was referenced Jul 9, 2021
@MichaelChirico
Copy link
Collaborator

TODO: put an item about changes to default_linters in the "breaking changes" section at the top

@MichaelChirico
Copy link
Collaborator

#1061 (comment)

lintr/NEWS.md

Line 11 in fc6cb37

* The `...` arguments for `lint()`, `lint_dir()`, and `lint_package()` have promoted to an earlier position to better match the [Tidyverse design principal](https://design.tidyverse.org/args-data-details.html) of data->descriptor->details. This change enables passing objects to `...` without needing to specify non-required arguments, e.g. `lint_dir("/path/to/dir", linter())` now works without the need to specify `relative_path`. This affects some code that uses positional arguments. (#935, @michaelchirico)

@AshesITR
Copy link
Collaborator Author

TODO explain what flexibility was lost to #1041 (unification of brace related linters)

@MichaelChirico
Copy link
Collaborator

Leaving this as open for now to force us to take one more pass before release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants