Skip to content

Parsed data in XML via xmlparsedata #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2016
Merged

Parsed data in XML via xmlparsedata #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67af424
Parsed data in XML via xmlparsedata
gaborcsardi May 21, 2016
c7232ca
Add xml_parse_data bullet point to the NEWS
gaborcsardi May 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ Imports:
jsonlite,
knitr,
stats,
utils
utils,
xml2,
xmlparsedata
Remotes: MangoTheCat/xmlparsedata
Suggests:
rmarkdown
License: MIT + file LICENSE
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# lintr 1.0.0.9000 #
* linters can use the XML parse tree as well now, via the
https://github.com/MangoTheCat/xmlparsedata package (#154, @gaborcsardi)

* lintr does not need the igraph package any more (#152, @gaborcsardi)

* trailing_semicolon_linter (#147, @gaborcsardi)
Expand Down
1 change: 1 addition & 0 deletions R/get_source_expressions.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ get_source_expressions <- function(filename) {
column = parsed_content[loc, "col1"],
lines = expr_lines,
parsed_content = pc,
xml_parsed_content = xml2::read_xml(xmlparsedata::xml_parse_data(pc)),
content = content,

find_line = find_line_fun(content),
Expand Down