Skip to content

Remove code to deal with broken namespaces #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 9, 2022
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

Closes #1650

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #1653 (e9df966) into main (35f50e6) will increase coverage by 0.21%.
The diff coverage is 94.44%.

❗ Current head e9df966 differs from pull request most recent head 02fb726. Consider uploading reports for the commit 02fb726 to get more accurate results

@@            Coverage Diff             @@
##             main    #1653      +/-   ##
==========================================
+ Coverage   98.27%   98.48%   +0.21%     
==========================================
  Files         100      101       +1     
  Lines        4394     4436      +42     
==========================================
+ Hits         4318     4369      +51     
+ Misses         76       67       -9     
Impacted Files Coverage Δ
R/equals_na_linter.R 100.00% <ø> (ø)
R/expect_comparison_linter.R 100.00% <ø> (ø)
R/expect_identical_linter.R 100.00% <ø> (ø)
R/expect_length_linter.R 100.00% <ø> (ø)
R/expect_named_linter.R 100.00% <ø> (ø)
R/expect_not_linter.R 100.00% <ø> (ø)
R/expect_null_linter.R 100.00% <ø> (ø)
R/expect_s3_class_linter.R 100.00% <ø> (ø)
R/expect_true_false_linter.R 100.00% <ø> (ø)
R/expect_type_linter.R 100.00% <ø> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil IndrajeetPatil merged commit 09adcf3 into main Oct 9, 2022
@IndrajeetPatil IndrajeetPatil deleted the 1650_broken_ns branch October 9, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-evaluate if code to deal with a broken NAMESPACE is needed by namespace_linter()
3 participants