Add linter for no spaces before function calls #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This linter checks that for function calls there is no space before the parentheses. This is almost the inverse of the which checks for spaces before parentheses *except* when it is a function. This only considers function calls and not after , brackets instead of parentheses, or after curly brackets, square brackets, or parentheses. I didn't know if they belonged in this or another linter. This linter handles cases like which should be .
jrnold
changed the title
Changes to xml2 meant that this testthat test was failing. Fix it to pass Travis.
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=========================================
+ Coverage 81.31% 82.11% +0.8%
=========================================
Files 30 31 +1
Lines 1702 1728 +26
=========================================
+ Hits 1384 1419 +35
+ Misses 318 309 -9
Continue to review full report at Codecov.
|
jrnold
changed the title
|
I think this looks good, could you add a note to NEWS.md? |
|
I put the note under |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies if I missed a linter that was already defined; I looked but I couldn't find it (althoug
This adds a new linter,
function_left_parentheses_linter, which checks that for function calls there is no space before the parentheses. This is almost the inverse of thespaces_left_parentheses_linter, which checks for spaces before parentheses except when it is a function.This only considers function calls and not after , brackets instead of parentheses, or after curly brackets, square brackets, or parentheses. I didn't know if they belonged in this or another linter.
This linter handles cases like
print (blah)which should beprint(blah).