unreachable_code_linter() lints on code in if (FALSE), while (FALSE)

[MEO265]

Resolves #1428.

I held back from linting comments with the new features since, unlike the previous linting scenario, I don't see any issues with it and didn't find any guidelines on this in the tidyverse style guide. But I'm open to tweaking this if needed. Maybe we could even add a flag for this option?

Empty loops are intentionally ignored.

When I get a moment, I'm also planning to tackle issue #2105.

I noticed that the previous examples each contained an unnecessary line in my opinion, but I didn't want to just change it. Am I missing something why writeLines(code_lines) is necessary?

[codecov-commenter]

Codecov Report

Merging #2123 (17fc0bf) into main (739b4b6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 17fc0bf differs from pull request most recent head a48aedc. Consider uploading reports for the commit a48aedc to get more accurate results

@@           Coverage Diff           @@
##             main    #2123   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         121      121           
  Lines        5232     5258   +26     
=======================================
+ Hits         5214     5240   +26     
  Misses         18       18           

Files Changed	Coverage Δ
R/unreachable_code_linter.R	100.00% <100.00%> (ø)

[MEO265]

I have seen the lints; I will correct them.

[AshesITR]

Good work. Don't forget to add a NEWS bullet.

[MichaelChirico]

I held back from linting comments

Makes sense to me... even though some such comments should likely be removed, some are OK, and we won't have a way to distinguish them that I can think of.

[MichaelChirico]

I held back from linting comments

OTOH, what about cases like this?

if (FALSE) {
  # some_code()
  # that_i_commented_out()
  # that_should_be_removed()
}

[MichaelChirico]

Overall, looks good! Thanks for taking this on!

[MEO265]

I held back from linting comments

OTOH, what about cases like this?

if (FALSE) {
  # some_code()
  # that_i_commented_out()
  # that_should_be_removed()
}

I think linter should have independent separate tasks and that would be the commented_code_linter's job