Skip to content

Also handle 'single-quoted' library calls in sapply() for libary_call_linter() #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2319

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (9565050) 99.40% compared to head (fe6ad40) 99.10%.
Report is 24 commits behind head on main.

❗ Current head fe6ad40 differs from pull request most recent head 8475eae. Consider uploading reports for the commit 8475eae to get more accurate results

Files Patch % Lines
R/lintr-deprecated.R 28.57% 20 Missing ⚠️
R/with.R 72.72% 3 Missing ⚠️
R/path_utils.R 71.42% 2 Missing ⚠️
R/extract.R 0.00% 1 Missing ⚠️
R/lint.R 95.65% 1 Missing ⚠️
R/object_name_linter.R 75.00% 1 Missing ⚠️
R/object_overwrite_linter.R 93.75% 1 Missing ⚠️
R/return_linter.R 98.24% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2368      +/-   ##
==========================================
- Coverage   99.40%   99.10%   -0.31%     
==========================================
  Files         123      125       +2     
  Lines        5584     5672      +88     
==========================================
+ Hits         5551     5621      +70     
- Misses         33       51      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshesITR AshesITR merged commit 67754bc into main Dec 4, 2023
@AshesITR AshesITR deleted the cosq branch December 4, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch single-quotes FUN when looking for character.only=TRUE in library_call_linter()
4 participants