fix symbols style #698
Merged
fix symbols style #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #495 the major issue was that `as.character()` doesn't unescape XML entities. `xml2::xml_text()` should have been used instead.
AshesITR
commented
Dec 9, 2020
AshesITR
commented
Dec 9, 2020
| @@ -283,7 +284,7 @@ loweralnum <- rex(one_of(lower, digit)) | |||
| upperalnum <- rex(one_of(upper, digit)) | |||
|
|
|||
| style_regexes <- list( | |||
| "symbols" = rex(start, maybe("."), zero_or_more(none_of(alnum)), end), | |||
| "symbols" = rex(start, zero_or_more(none_of(alnum)), end), | |||
There was a problem hiding this comment.
The empty name can occur here because symbols like <- are stripped before passing on to the regex.
There was a problem hiding this comment.
this feels somewhat hacky... but OK for now.
There was a problem hiding this comment.
The reason is the other styles should allow e.g. snake_case<- as a function name
There was a problem hiding this comment.
As long as applying those rules in the same order always works, we're OK, I'm just not 100% sure of that.
MichaelChirico
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #495
the major issue was that
as.character()doesn't unescape XML entities.xml2::xml_text()should have been used instead.