Fix uninformative collection errors for non-mirai errorValues - #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stop_m()read amessageattribute that only a 'miraiError' carries, so.stop/.flatcollection of a cancelled, timed-out, or connection-reset task raised a bare "In index: 1." with cli, and an entirely empty message without it.The message is now derived by error kind: the message attribute for a 'miraiError' as before,
nng_error()for integer 'errorValue's (which includes the code, e.g. "20 | Operation canceled"), and "Interrupted" for a 'miraiInterrupt'. The cli branch gains a propererrorCondition()parent so the cause is reported in the chain. All changes are on the terminal error path, so there is no impact on collection hot paths.The test forces the base branch via
cli_enabledto stay meaningful on runners with cli but not rlang, and matches "In index", which the pre-fix empty message fails.Closes #642.