Skip to content

Make build subprocess use specified libpath #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: rcmdcheck
Title: Run 'R CMD check' from 'R' and Capture Results
Version: 1.4.0.9000
Version: 1.4.0.9001
Authors@R: c(
person("Gábor", "Csárdi", , "[email protected]", role = c("cre", "aut")),
person("Mango Solutions", role = c("cph", "fnd")),
Expand Down Expand Up @@ -42,4 +42,4 @@ Config/Needs/website: tidyverse/tidytemplate
Config/testthat/edition: 3
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.1
RoxygenNote: 7.3.2
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,5 @@ importFrom(utils,tail)
importFrom(withr,local_path)
importFrom(withr,with_dir)
importFrom(withr,with_envvar)
importFrom(withr,with_libpaths)
importFrom(xopen,xopen)
4 changes: 3 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@

# rcmdcheck (development version)

* Fixed an issue where check output could be malformed when testing
packages with multiple test files (#205, @kevinushey).

* Update pkgdown template and move url to https://rcmdcheck.r-lib.org.

* Fixed and issue where `rcmdcheck_process$new()` could fail the setup stage
due to `libpath` not being used by the build sub process. (#230, @maksymiuks)

# rcmdcheck 1.4.0

* `cran_check_results()` now downloads results in parallel, so it is
Expand Down
5 changes: 2 additions & 3 deletions R/build.R
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

#' @importFrom pkgbuild pkgbuild_process
#' @importFrom withr with_envvar
#' @importFrom withr with_libpaths

build_package <- function(path, tmpdir, build_args, libpath, quiet) {
path <- normalizePath(path)
Expand All @@ -16,8 +16,7 @@ build_package <- function(path, tmpdir, build_args, libpath, quiet) {
desc <- desc(path)
clean_doc <- as_flag(desc$get("Config/build/clean-inst-doc"), NULL)

with_envvar(
c("R_LIBS_USER" = paste(libpath, collapse = .Platform$path.sep)), {
with_libpaths(libpath, {
proc <- pkgbuild_process$new(
path,
tmpdir,
Expand Down
20 changes: 20 additions & 0 deletions man/rcmdcheck.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading