solve eq_sub indention in general #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
approved these changes
Aug 14, 2017
| x | ||
| } | ||
| }, | ||
| new = ( |
There was a problem hiding this comment.
This pattern is rare enough, but what happens if we use {} instead of ()?
There was a problem hiding this comment.
Like at line 2 you mean? It also indents by two spaces.
There was a problem hiding this comment.
Yes, but what happens to the closing brace?
There was a problem hiding this comment.
It is unindented
switch(engine,
pdftex = {
if (any) {
x
}
},
new = {
2
})
{
a <-
3
}There was a problem hiding this comment.
Could you please add a FIXME that refers to #125?
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 88.6% 88.65% +0.05%
==========================================
Files 18 18
Lines 676 679 +3
==========================================
+ Hits 599 602 +3
Misses 77 77
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #126