lorenzwalthert_medium #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzwalthert
force-pushed
the
lorenzwalthert_medium
branch
from
112ca85 to
7a1d347
Compare
lorenzwalthert
force-pushed
the
lorenzwalthert_medium
branch
from
7a1d347 to
8bcea3c
Compare
|
Thanks. We should eventually add a test, but that will be part of getting close to full test coverage. Mocking can be done with |
lorenzwalthert
added a commit
that referenced
this pull request
Jun 23, 2017
Style correct when code does not start on first line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be consistent with
style_pkg(), I usedwithr::with_dirto perform the styling. This, at the same time, means that the message printed (bytransform_lines_encinternally) at the end of the styling to indicate which files were changed shows the paths relative to the temporary working directory used bywithr::with_dirand not the directory that was the working directory before and after the execution ofstyle_src(). If this is confusing, we have to do it withoutwithr::with_dir, but then it would not be consistent anymore withstyle_pkg(), so I guess we can do it as proposed in this PR.To increase the flexibility of the function regarding files in sub directories,
style_src()has an argumentrecursivethat will be passed todirinternally, so the user can choose whether to style files in just the selected directory or also in all sub-directories.