-
Notifications
You must be signed in to change notification settings - Fork 21
ci: Add Linux Arm runner #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ci: Add Linux Arm runner #24
Conversation
It seems that the R on the PATH is not arm64 version.
|
.github/workflows/R-CMD-check.yaml
Outdated
# TODO: skip installation on Windows Arm64 and use the default installation | ||
if: ${{ !(runner.os == 'windows' && runner.arch == 'ARM64') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this support windows-11-arm? 🤔
https://github.com/r-lib/actions/blob/bd49c52ffe281809afa6f0fecbf37483c5dd0b93/setup-r/src/installer.ts#L474-L477
Oh, I didn't notice setup-r is ready for Rtools for ARM. But, it didn't work. |
It seems it's way too early to try to support Windows ARM. Even if I tweaked
I'm giving up for now! |
Setting up R and Rtools isn't that difficult. You can just tweak a few lines of r-lib/actions/setup-r instead of writing that PowerShell from scratch! However,
|
Unrelated, but the r-svn CI does build on arm64: https://github.com/r-devel/r-svn |
edit: I found it's too difficult to test Windows ARM at the moment. So, this pull request was changed to just adding a
ubuntu-24.04-arm
runner.GitHub now provides Windows Arm64 runner.https://github.blog/changelog/2025-04-14-windows-arm64-hosted-runners-now-available-in-public-preview/I know hellorust had been ready for Arm64 from a long ago, so, I expected this pull request was just for ensuring it. However, it seems the R installation reportsR.version$platform
asx86_64-w64-mingw32
, which makes this logic fail. So, please do not merge this for now.hellorust/tools/rustarch.R
Lines 3 to 4 in 0f2dc03