Skip to content

ci: Add Linux Arm runner #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yutannihilation
Copy link
Contributor

@yutannihilation yutannihilation commented Apr 15, 2025

edit: I found it's too difficult to test Windows ARM at the moment. So, this pull request was changed to just adding a ubuntu-24.04-arm runner.

GitHub now provides Windows Arm64 runner.

https://github.blog/changelog/2025-04-14-windows-arm64-hosted-runners-now-available-in-public-preview/

I know hellorust had been ready for Arm64 from a long ago, so, I expected this pull request was just for ensuring it. However, it seems the R installation reports R.version$platform as x86_64-w64-mingw32, which makes this logic fail. So, please do not merge this for now.

arch <- if(grepl("aarch", R.version$platform)){
"aarch64-pc-windows-gnullvm"

@eitsupi
Copy link
Contributor

eitsupi commented Apr 15, 2025

It seems that the R on the PATH is not arm64 version.
https://github.com/r-rust/hellorust/actions/runs/14471329390/job/40585772582?pr=24#step:9:23

  shell: C:\Program Files (x86)\R\R-4.4.2\bin\x64\Rscript.EXE {0}

Comment on lines 51 to 52
# TODO: skip installation on Windows Arm64 and use the default installation
if: ${{ !(runner.os == 'windows' && runner.arch == 'ARM64') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yutannihilation
Copy link
Contributor Author

Oh, I didn't notice setup-r is ready for Rtools for ARM. But, it didn't work.

https://github.com/yutannihilation/hellorust/actions/runs/14470417956/job/40582638349

@yutannihilation
Copy link
Contributor Author

It seems it's way too early to try to support Windows ARM. Even if I tweaked setup-r action to work, I found

  • setup-r-dependencies doesn't work: there is no package called 'pak'
  • rcmdcheck doesn't work: Error in get(name, envir = cache) : object 'rtools_path' not found

I'm giving up for now!

@yutannihilation yutannihilation changed the title ci: Add Windows and Linux Arm runner ci: Add Linux Arm runner Apr 26, 2025
@yutannihilation yutannihilation marked this pull request as ready for review April 26, 2025 01:44
@eitsupi
Copy link
Contributor

eitsupi commented Apr 26, 2025

@yutannihilation
Copy link
Contributor Author

Setting up R and Rtools isn't that difficult. You can just tweak a few lines of r-lib/actions/setup-r instead of writing that PowerShell from scratch! However,

  • setup-r-dependencies and check-r-package don't work.
  • Also, I'm not sure if https://www.r-project.org/nosvn/ is a place where we can use for CI.

@jeroen
Copy link
Member

jeroen commented Apr 26, 2025

Unrelated, but the r-svn CI does build on arm64: https://github.com/r-devel/r-svn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants