Transactions: Allow re module#41
Merged
Merged
Conversation
However, `re:version/0` is denied: it could return a different result on
different nodes.
For `re:compile/{1,2}`, it is more complicated. The compiled regex could
be very specific to a version of the PCRE engine and not portable to
another node. It is fine to compile a regex and use it in the same
function (transaction). But storing it in Khepri and using it on another
node than the one which compiled it could break. This API is still
allowed because there is no way for us to prevent a compiled regex to
come from outside a transaction function or to be stored by
`khepri_machine:put/3` for instance.
Pull Request Test Coverage Report for Build 284
💛 - Coveralls |
Pull Request Test Coverage Report for Build 284
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
However,
re:version/0is denied: it could return a different result on different nodes.For
re:compile/{1,2}, it is more complicated. The compiled regex could be very specific to a version of the PCRE engine and not portable to another node. It is fine to compile a regex and use it in the same function (transaction). But storing it in Khepri and using it on another node than the one which compiled it could break. This API is still allowed because there is no way for us to prevent a compiled regex to come from outside a transaction function or to be stored bykhepri_machine:put/3for instance.