Accept binaries for Unix-like paths#93
Merged
Merged
Conversation
dumbbell
force-pushed
the
accept-binary-for-unix-path
branch
2 times, most recently
from
May 2, 2022 12:02
9d4be44 to
e1fff67
Compare
This is especially handy for Beam languages which use Erlang binaries to implement strings, such as Elixir or Gleam. To achieve that, `khepri_path:from_string/1` is expanded to accept Erlang binaries. The implementation is very basic: the binary is converted to a list. We also introduce `from_binary/1` which just calls `from_string/1`. So they both accept all representations of paths. `from_binary/1` is for convenience and to make it clear that Erlang binaries are accepted. `to_string/1` will always return an Erlang string however. To produce a binary, there is now `to_binary/1`. Fixes #92.
dumbbell
force-pushed
the
accept-binary-for-unix-path
branch
from
May 2, 2022 12:05
e1fff67 to
05b21d1
Compare
Pull Request Test Coverage Report for Build 586
💛 - Coveralls |
Pull Request Test Coverage Report for Build 586
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is especially handy for Beam languages which use Erlang binaries to implement strings, such as Elixir or Gleam.
To achieve that,
khepri_path:from_string/1is expanded to accept Erlang binaries. The implementation is very basic: the binary is converted to a list.We also introduce
from_binary/1which just callsfrom_string/1. So they both accept all representations of paths.from_binary/1is for convenience and to make it clear that Erlang binaries are accepted.to_string/1will always return an Erlang string however. To produce a binary, there is nowto_binary/1.Fixes #92.