Rabbitmq 6.0, ReplyToAddress getter throws ArgumentNullException

[ig-sinicyn]

RabbitMQ.Client 6.0.0
Code:

var address = message.Properties.ReplyToAddress; // ReplyTo is null

throws ArgNullException, callstack:

System.Text.RegularExpressions.dll!System.Text.RegularExpressions.Regex.Match(string input)
RabbitMQ.Client.dll!RabbitMQ.Client.PublicationAddress.Parse(string uriLikeString)
RabbitMQ.Client.dll!RabbitMQ.Client.Impl.BasicProperties.ReplyToAddress.get()

[lukebakken]

Yes, it is working as documented:

https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/master/projects/RabbitMQ.Client/client/impl/BasicProperties.cs#L111-L120

If you have a suggestion for improvement, please open a pull request, link to this issue, and I will re-open this issue.

Thanks!

[ig-sinicyn]

I'd prefer the property to return null.

It's a bad practice to throw on getters. Most code does not expect such behavior.

In our case we have a process crash due to the unhandled exception in the serilog logger thread.
The message.Properties object was passed as argument to the LogTrace() call. Serilog attempted to deconstruct it and fall on ReplyToAddress getter.

It's a not major issue for us but may affect other customers, too.

[lukebakken]

A pull request with test would be greatly appreciated, thanks.

[ig-sinicyn]

Done, #828