Delete recorded consumers when autorecovering model is disposed#1317
Merged
lukebakken merged 1 commit into6.xfrom Mar 22, 2023
Merged
Delete recorded consumers when autorecovering model is disposed#1317lukebakken merged 1 commit into6.xfrom
lukebakken merged 1 commit into6.xfrom
Conversation
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1302
branch
6 times, most recently
from
8d80556 to
8928e0a
Compare
Zerpet
reviewed
Mar 21, 2023
Member
Zerpet
left a comment
Zerpet
left a comment
There was a problem hiding this comment.
The changes look reasonable, although CI/Actions seems unhappy.
Collaborator
Author
|
Hmm I appear to have broken something 😉 |
lukebakken
changed the title
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1302
branch
from
cfcec5d to
fdd0fa4
Compare
lukebakken
changed the title
lukebakken
commented
Mar 21, 2023
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1302
branch
from
fdd0fa4 to
63b0a82
Compare
Fixes #1302 Update dependencies Ensure RecordedConsumer has a ConsumerTag
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1302
branch
from
63b0a82 to
bda44c9
Compare
Zerpet
reviewed
Mar 22, 2023
Member
|
@lukebakken should we port this to |
Collaborator
Author
|
Yep, I'm getting it right now. I can't even cherry-pick anymore since |
lukebakken
added a commit
that referenced
this pull request
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1302