Pass exception back up to application code#1438
Merged
lukebakken merged 1 commit into6.xfrom Dec 5, 2023
Merged
Conversation
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1434
branch
from
781a2d1 to
169a6d1
Compare
Collaborator
Author
|
@pabermod - Please give my fix a review and test. I added your test project to this project's solution, on a temporary basis, to make it easy to debug. Be sure to update submodules: |
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1434
branch
from
169a6d1 to
a319092
Compare
|
This fix is working as expected. Thanks! |
Collaborator
Author
|
@pabermod thank you for testing this so quickly! |
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1434
branch
from
a319092 to
ed7b4e6
Compare
Closed
lukebakken
added a commit
that referenced
this pull request
Dec 11, 2023
Merged
patrikwlund
added a commit
to patrikwlund/AddUp.FakeRabbitMQ
that referenced
this pull request
Dec 11, 2023
The RabbitMQ client introduced a breaking API change in a constructor in 6.8.0: rabbitmq/rabbitmq-dotnet-client#1438 So this lib needs to be recompiled against the new version of RabbitMQ to be fully compatible.
lukebakken
added a commit
that referenced
this pull request
Dec 11, 2023
The original change in #1438 introduced a breaking API change, reported here: addupsolutions/AddUp.FakeRabbitMQ#189
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1434