Add CancellationToken to Async members of IChannel#1535
Merged
lukebakken merged 1 commit intomainfrom Apr 20, 2024
Merged
Conversation
lukebakken
changed the title
Async members of IChannelCancellationToken to Async members of IChannel
* `BasicAckAsync` * `BasicNackAsync` * `BasicRejectAsync` * `BasicCancelAsync` * Add `CancellationToken` to `BasicPublishAsync` * Add `CancellationToken` to a couple more places. * Remove dead code * Add a few more TODOs for cancellation tokens * Add cancellation token to `BasicConsumeAsync` * Add cancellation token to `BasicGetAsync` * Add cancellation token to `BasicQosAsync` * Add cancellation token to `CloseAsync` * Add cancellation token to `ConfirmSelectAsync` * Add cancellation token to `ExchangeBindAsync` * Add cancellation token to `ExchangeDeclareAsync` and `ExchangeDeclarePassiveAsync` * Add cancellation token to `ExchangeDeleteAsync` * Add cancellation token to `ExchangeUnbindAsync` * Add cancellation token to remainder of `IChannel` * Ensure that token source is disposed correctly in async rpc continuations
lukebakken
force-pushed
the
lukebakken/finish-cancellation-token-todos
branch
from
abde277 to
3df46cc
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: