Fix exception when refreshing oauth2 token#1690
Merged
lukebakken merged 1 commit intorabbitmq:mainfrom Oct 3, 2024
Merged
Conversation
Collaborator
|
Thank you for this PR @BreakingBread0. Would you mind sharing which version of this library you found this issue in? |
Author
The versions I currently use (and in which I found the bug) are:
|
ec0f472 to
1dab877
Compare
lukebakken
approved these changes
Oct 2, 2024
Collaborator
lukebakken
left a comment
There was a problem hiding this comment.
Thank you @BreakingBread0
lukebakken
added a commit
that referenced
this pull request
Oct 3, 2024
lukebakken
added a commit
that referenced
this pull request
Oct 3, 2024
This was referenced Jul 29, 2025
This was referenced Aug 5, 2025
This was referenced Aug 17, 2025
This was referenced Sep 15, 2025
This was referenced Oct 20, 2025
This was referenced Nov 24, 2025
This was referenced Dec 2, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This fixes a small bug that happens when refreshing the OAuth2 access token from the OAuth backchannel provider. The dictionary key "scope" in BuildRefreshParameters is already set in BuildRequestParameters and therefore this throws an exception.
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
Before being added to the dictionary, _scope undergoes two different checks: Nullability and string.IsNullOrEmpty in the two aforementioned methods. I do not know if this is intentional or not.