Ensure broker-originated channel closure completes

[lukebakken]

Fixes #1749

• Ensure Dispose and DisposeAsync are idempotent and thread-safe.
• Use TaskCompletionSource when HandleChannelCloseAsync runs to allow dispose methods to wait.

[danielmarbach]

Here are my thoughts #1761. I try to make individual commits so that you can drop them as needed / desired

[danielmarbach]

Do you always remove the co-authors when force pushing? That seems unnecessary to me

[lukebakken]

No I don't do anything special when force-pushing. I thought that co-authors were preserved! 😬

[lukebakken]

Well crap, I now see that your contribution is lost on that one commit. I'll try to figure out what I may have done differently.

[danielmarbach]

It's not the end of the world. In my heart I know I was there 😆

[lukebakken]

Do you have any idea what I may be doing when I rebase and force-push? This last time, I did the following:

git checkout main
git pull
git checkout rabbitmq-dotnet-client-1749
git rebase -i main
# interactive rebase
git push --force

I squashed all of the commits during the interactive rebase, and I re-worded some of the commit messages. I wonder if it is the re-wording that changes things, or if its the squash? I swear this didn't used to happen 🤔

[danielmarbach]

Did you preserve the Co-authored-by: stuff when you reworded or did the interactive rebase? If you drop that, the co-author is lost.

[lukebakken]

I just read about that. I didn't intentionally remove Co-Authored-By but that's the most likely explanation.

[lukebakken]

@danielmarbach - fixed in #1764. I'll hopefully not do that again!