Added TryComplete instead of comple during channel shutdown#1885
Merged
lukebakken merged 1 commit intorabbitmq:mainfrom Jan 12, 2026
Merged
Conversation
Contributor
|
@lukebakken any reasons to not accept this PR? |
Collaborator
|
Nope, I just haven't had time to return to this. |
lukebakken
force-pushed
the
patrik/1884_fixShutdownThreadingChannel
branch
from
1e676e4 to
3bcd62e
Compare
This was referenced Feb 26, 2026
hwinther
pushed a commit
to hwinther/test
that referenced
this pull request
Mar 7, 2026
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Updated [RabbitMQ.Client](https://github.com/rabbitmq/rabbitmq-dotnet-client) from 7.2.0 to 7.2.1. <details> <summary>Release notes</summary> _Sourced from [RabbitMQ.Client's releases](https://github.com/rabbitmq/rabbitmq-dotnet-client/releases)._ ## 7.2.1 [GitHub milestone](https://github.com/rabbitmq/rabbitmq-dotnet-client/milestone/77?closed=1) ## What's Changed * Add 'contents: read' to workflow permissions to increase the OpenSSF scorecard of the repo by @pavlofilatov1 in rabbitmq/rabbitmq-dotnet-client#1880 * Add workflow to check for GHA updates by @lukebakken in rabbitmq/rabbitmq-dotnet-client#1887 * Update GHA via `actions-up` by @lukebakken in rabbitmq/rabbitmq-dotnet-client#1886 * Added TryComplete instead of comple during channel shutdown by @patriktiain in rabbitmq/rabbitmq-dotnet-client#1885 * Catch all exceptions in HeartbeatWriteTimerCallback and HeartbeatReadTimerCallback to avoid crash by @klettier in rabbitmq/rabbitmq-dotnet-client#1876 * Use dependabot to update actions refs by @lukebakken in rabbitmq/rabbitmq-dotnet-client#1896 * Bump github/codeql-action from 3 to 4 by @dependabot[bot] in rabbitmq/rabbitmq-dotnet-client#1898 * Bump actions/checkout from 6.0.1 to 6.0.2 by @dependabot[bot] in rabbitmq/rabbitmq-dotnet-client#1897 * Bump actions/cache from 5.0.2 to 5.0.3 by @dependabot[bot] in rabbitmq/rabbitmq-dotnet-client#1899 * Fix unconditional semaphore release in BasicPublishAsync when Cancell… by @EvheniyHlushko in rabbitmq/rabbitmq-dotnet-client#1901 * Connection recovery: remove recorded bindings of auto-delete entities by @michaelklishin in rabbitmq/rabbitmq-dotnet-client#1906 * Pre-7.2.1 release preparation by @lukebakken in rabbitmq/rabbitmq-dotnet-client#1909 ## New Contributors * @pavlofilatov1 made their first contribution in rabbitmq/rabbitmq-dotnet-client#1880 * @patriktiain made their first contribution in rabbitmq/rabbitmq-dotnet-client#1885 * @klettier made their first contribution in rabbitmq/rabbitmq-dotnet-client#1876 * @dependabot[bot] made their first contribution in rabbitmq/rabbitmq-dotnet-client#1898 * @EvheniyHlushko made their first contribution in rabbitmq/rabbitmq-dotnet-client#1901 **Full Changelog**: rabbitmq/rabbitmq-dotnet-client@v7.2.0...v7.2.1 Commits viewable in [compare view](rabbitmq/rabbitmq-dotnet-client@v7.2.0...v7.2.1). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Change from Threading.Channel.Complete() to TryComplete() to catch any race conditions. Race condition can occur if another thread already have called complete on this channel.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
CONTRIBUTING.mddocumentFurther Comments