Conversation
lukebakken
force-pushed
the
rabbitmq-dotnet-client-745
branch
from
452c780 to
ed9d7d7
Compare
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)' == 'SignedRelease' "> | ||
| <DelaySign>true</DelaySign> | ||
| <PropertyGroup Condition=" '$(Configuration)' == 'Release' "> |
There was a problem hiding this comment.
I'd remove this PropertyGroup entirely. The only things in it that aren't redudant are AssemblyOriginatorKeyFile and SignAssembly, so you can move those up to the top PropertyGroup and get rid of everything else.
| <PackageReference Include="System.Memory" Version="4.5.3" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition=" '$(Configuration)' == 'SignedRelease' "> | ||
| <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleToAttribute"> |
There was a problem hiding this comment.
Since it make sense to always strong-name the assembly, I'd move this one out of the project file and into AssemblyInfo.cs as an actual attribute.
|
@bording as always thanks for the guidance. |
| <IncludeSymbols>true</IncludeSymbols> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder> | ||
| <OutputType>Library</OutputType> |
| <OutputType>Library</OutputType> | ||
| <AssemblyOriginatorKeyFile>../rabbit.snk</AssemblyOriginatorKeyFile> | ||
| <SignAssembly>true</SignAssembly> | ||
| <DelaySign>false</DelaySign> |
| <SignAssembly>true</SignAssembly> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)' != 'Release' "> | ||
| <Optimize>false</Optimize> |
There was a problem hiding this comment.
This isn't needed, so you an remove this entire PropertyGroup and the Optimize setting.
| <DelaySign>true</DelaySign> | ||
| <OutputType>Library</OutputType> | ||
| <PropertyGroup Condition=" '$(Configuration)' == 'Release' "> | ||
| <Optimize>true</Optimize> |
There was a problem hiding this comment.
You don't need to set Optmize at all, so you can remove everything related to that.
projects/client/Unit/Unit.csproj
Outdated
| <GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute> | ||
| <AssemblyOriginatorKeyFile>../rabbit.snk</AssemblyOriginatorKeyFile> | ||
| <SignAssembly>true</SignAssembly> | ||
| <DelaySign>false</DelaySign> |
| using System; | ||
| using System.Threading; | ||
|
|
||
| #pragma warning disable CS0649 |
There was a problem hiding this comment.
Hmm, this is interesting. What problem are you running into here?
There was a problem hiding this comment.
I was getting a build warning but now I'm not. Bizarre.
There was a problem hiding this comment.
It was a warning about this line being unassigned and thus keeping its default value.
lukebakken
force-pushed
the
rabbitmq-dotnet-client-745
branch
from
0952c7c to
188f23e
Compare
https://docs.microsoft.com/en-us/dotnet/core/tools/telemetry Add strong-named secret file Removed SignedRelease build, other SNK releated cleanup Since we're always signing RabbitMQ.Client we need to sign Unit as well
lukebakken
force-pushed
the
rabbitmq-dotnet-client-745
branch
from
188f23e to
c8a669c
Compare
Always sign builds (cherry picked from commit 20cc528)
|
Backported to |
2 participants
Fixes #745