AutorecoveringConnection uses ContinuationTimeout from ConnectionFactory#823
Merged
michaelklishin merged 1 commit intorabbitmq:masterfrom May 4, 2020
Conversation
michaelklishin
approved these changes
May 4, 2020
Contributor
|
Thank you! |
michaelklishin
added a commit
that referenced
this pull request
May 4, 2020
…_ConnectionFactory AutorecoveringConnection uses ContinuationTimeout from ConnectionFactory (cherry picked from commit c9e36dc)
Contributor
|
Backported to |
|
Thanks a lot, guys 👍 |
This was referenced Jul 29, 2025
This was referenced Aug 5, 2025
This was referenced Aug 17, 2025
This was referenced Sep 15, 2025
This was referenced Oct 20, 2025
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
This was referenced Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is to address issue #821. ContinuationTimeout set on Connection Factory was ignored if AutomaticRecoveryEnabled was set to
true. Exact same behavior is already implemented for non-auto recovery connection:rabbitmq-dotnet-client/projects/client/RabbitMQ.Client/src/client/impl/Connection.cs
Line 1207 in 93cdd66
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocument